Skip to content

Helium.doubleClick() Method Implemented - #14

Merged
vimscientist69 merged 2 commits into
mainfrom
feat/helium-doubleclick-method
Aug 14, 2025
Merged

vimscientist69 merged 2 commits into
mainfrom
feat/helium-doubleclick-method

Conversation

@vimscientist69

@vimscientist69 vimscientist69 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Reason

Reason for creating this PR: fixes #13

Tech Details List

  1. Implemented Helium.doubleClick(), supporting both special element finder initializers (HeliumElement) and native Element.
  2. Working integration tests for doubleClick() method, with confirmation using JavaScript to manipulate the document on click and querying the document to see if it actually changed.
  3. Updated click() method integration tests to have click confirmation by manipulating the document on click and querying the document to see if it actually changed.

Tasks:

  • Implemented Helium.doubleClick(), supporting both special element finder initializers (HeliumElement) and native Element.
  • Working integration tests for doubleClick() method, with confirmation using JavaScript to manipulate the document on click and querying the document to see if it actually changed.
  • Updated click() method integration tests to have click confirmation by manipulating the document on click and querying the document to see if it actually changed.

Un-important tasks:

Links:

ISSUE-13
closes/resolves #13

Testing

Steps:

  1. Run required commands to test all the code modified by this PR
# unit tests
# integration tests
npm run compose:build-and-up
swift build
swift test --filter "ClickOnlyMethodIntegrationTests"
swift test --filter "DoubleClickMethodIntegrationTests"
# procs / testing logic
  1. Further testing can be done by following the notes in TESTING-QA

Output:

❯ swift build
swift test --filter "ClickOnlyMethodIntegrationTests"
swift test --filter "DoubleClickMethodIntegrationTests"

[1/1] Planning build
Building for debugging...
[1/1] Write swift-version--58304C5D6DBC2206.txt
Build complete! (2.68s)
[1/1] Planning build
Building for debugging...
[6/6] Linking HeliumSwiftPackageTests
Build complete! (4.29s)
Test Suite 'Selected tests' started at 2025-08-14 10:35:11.665.
Test Suite 'HeliumSwiftPackageTests.xctest' started at 2025-08-14 10:35:11.672.
Test Suite 'HeliumSwiftPackageTests.xctest' passed at 2025-08-14 10:35:11.672.
         Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.000) seconds
Test Suite 'Selected tests' passed at 2025-08-14 10:35:11.672.
         Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.006) seconds
◇ Test run started.
↳ Testing Library Version: 124.4
↳ Target Platform: arm64e-apple-macos14.0
✔ Test run with 0 tests passed after 0.001 seconds.
warning: No matching test cases were run
Building for debugging...
[1/1] Write swift-version--58304C5D6DBC2206.txt
Build complete! (0.21s)
Test Suite 'Selected tests' started at 2025-08-14 10:35:12.389.
Test Suite 'HeliumSwiftPackageTests.xctest' started at 2025-08-14 10:35:12.395.
Test Suite 'HeliumSwiftPackageTests.xctest' passed at 2025-08-14 10:35:12.395.
         Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.000) seconds
Test Suite 'Selected tests' passed at 2025-08-14 10:35:12.395.
         Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.006) seconds
◇ Test run started.
↳ Testing Library Version: 124.4
↳ Target Platform: arm64e-apple-macos14.0
◇ Suite "Double Click Method Integration Tests" started.
◇ Test "Double Click on HeliumElement" started.
✔ Test "Double Click on HeliumElement" passed after 3.234 seconds.
◇ Test "Double Click on SwiftWebDriver Element" started.
✔ Test "Double Click on SwiftWebDriver Element" passed after 2.892 seconds.
✔ Suite "Double Click Method Integration Tests" passed after 6.127 seconds.
✔ Test run with 2 tests passed after 6.127 seconds.

Testing QA

Make sure to run npm run compose:build-and-up

No integration tests written yet.
…ion tests for double click method, updated single click integration tests to validate whether element actually got clicked
@vimscientist69 vimscientist69 self-assigned this Aug 14, 2025
@vimscientist69
vimscientist69 merged commit fb66f8b into main Aug 14, 2025
3 checks passed
@vimscientist69
vimscientist69 deleted the feat/helium-doubleclick-method branch August 14, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature -> Helium.doubleClick()

1 participant