Fix issue #56 by increasing debounce time to 20 ms - #57
Open
sruggier wants to merge 1 commit into
Open
Conversation
On my own ANSI keyboard module (a rigorously chosen sample size of 1) this is necessary for the keyboard to work correctly. Otherwise, I frequently see duplicate key down events. I also tried 10 ms, and it was much better with that configuration, but I was still seeing the occasional bounce, so I doubled it to 20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my own ANSI keyboard module (a rigorously chosen sample size of 1) this is necessary for the keyboard to work correctly. Otherwise, I frequently see duplicate key down events.
I also tried 10 ms, and it was much better with that configuration, but I was still seeing the occasional bounce, so I doubled it to 20.
I wasn't sure whether to apply this to the four keyboard modules only, or to include the numpad and macropad as well, but I chose to start with all of them, because the consequences of the debounce time being too low are much worse than if it's set more conservatively than it needs to be. It would be nice if the debounce time were dynamically configurable without having to flash new firmware, but unless/until that happens, I think this is a safer default value.