Correct the behavior of PoolAllocator according to implementation of our internal allocator - #9152
Open
TreeHunter9 wants to merge 1 commit into
Open
TreeHunter9 wants to merge 1 commit into
TreeHunter9 wants to merge 1 commit into
Conversation
…f our internal allocator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::allocator_traitimplementation was not inline with how our internal allocator works. All assignment and swap operations must take into account which allocator is being used, so that we do not accidentally move data into a new object whose lifetime exceeds that of the pool to which the data is bound.