Fix/overlay portal semantics crash - #563
Merged
Merged
Conversation
Fix(zh-Hant): 修正天氣背景會在雲層著色器載入完的第一幀整片不見 Fix(en-US): fix the weather backdrop going blank for one frame after its cloud shader loads
lowrt
approved these changes
Sep 1, 2026
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+43
to
+49
| for p in "${patches[@]}"; do | ||
| name="$(basename "$p")" | ||
|
|
||
| # --forward alone is not enough to tell "applies" from "already applied": | ||
| # both refuse, with different messages. A reverse dry-run answers it | ||
| # directly — a patch that can be undone is a patch that is already in. | ||
| if patch -p1 -d "$sdk" --forward --dry-run --silent <"$p" >/dev/null 2>&1; then |
There was a problem hiding this comment.
由於 apply_sdk_patches.sh 會在每次透過 require_mise 初始化工具鏈時執行，且針對每個補丁都會進行兩次 patch --dry-run 檢查，隨著補丁數量增加，可能會導致開發者指令的啟動延遲。建議可以透過檢查 tool/patches/ 目錄的內容雜湊（hash）來實作快取機制，若雜湊未變動則跳過檢查。
Comment on lines
+49
to
+52
| if patch -p1 -d "$sdk" --forward --dry-run --silent <"$p" >/dev/null 2>&1; then | ||
| patch -p1 -d "$sdk" --forward --silent <"$p" | ||
| printf ' \033[33m●\033[0m patched SDK: %s\n' "$name" >&2 | ||
| elif patch -p1 -d "$sdk" --reverse --dry-run --silent <"$p" >/dev/null 2>&1; then |
There was a problem hiding this comment.
腳本使用了 GNU patch 特有的 --reverse 參數。在 macOS 等預設使用 BSD patch 的環境下，該參數可能不存在，導致工具鏈失效。建議在執行前檢查 patch 版本，或在文件說明中明確要求使用 GNU patch。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
相關 issue
怎麼驗
檢查清單
tool/check/commits.sh origin/main..HEAD通過—— commit 訊息就是更新日誌，格式見 commit.md
mise exec -- flutter analyze與mise exec -- flutter test通過AppLocalizations，沒有寫死AppSpacing/AppRadius/AppMotion，深色模式看過，文字對比度可接受