Skip to content

fix(memtrack): keep mmap/munmap/brk as deprecated artifact variants - #538

Merged
GuillaumeLagrange merged 1 commit into
mainfrom
re-add-legacy-events
Sep 16, 2026
Merged

GuillaumeLagrange merged 1 commit into
mainfrom
re-add-legacy-events

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

Refs COD-3492

Deserializing an unknown variant errors, and the stream iterator turns that
into end-of-stream, so one legacy event dropped the whole rest of the trace.

Refs COD-3492
@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the restored variants match the legacy artifact format and are covered by a focused compatibility test.

Summary

Restores deprecated memory-mapping event variants so artifacts produced by older memtrack versions remain decodable.

  • Reintroduces Mmap, Munmap, and Brk with their legacy wire-compatible payloads.
  • Adds a MessagePack fixture and regression test proving the stream continues through legacy events to subsequent allocation events.

Reviews (1) · Last reviewed commit: "fix(memtrack): keep mmap/munmap/brk as d..."

@codspeed

codspeed Bot commented Sep 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 17 untouched benchmarks


Comparing re-add-legacy-events (fd22dda) with main (af3867e)

Open in CodSpeed

@GuillaumeLagrange
GuillaumeLagrange merged commit f198706 into main Sep 16, 2026
85 of 87 checks passed
@GuillaumeLagrange
GuillaumeLagrange deleted the re-add-legacy-events branch September 16, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants