[ENG-12064] Phase 2: SSR performance & reliability metrics - #1049
Open
nsemets wants to merge 6 commits into
Open
[ENG-12064] Phase 2: SSR performance & reliability metrics#1049nsemets wants to merge 6 commits into
nsemets wants to merge 6 commits into
Conversation
brianjgeiger
requested changes
Sep 2, 2026
brianjgeiger
left a comment
Contributor
There was a problem hiding this comment.
Overall, looks good. I think it might be wise to also mark users as a type of 'user', since they are guid objects that won't necessarily be obvious from their url what they were.
|
|
||
| **Populated for:** projects, registrations, preprints, files. | ||
|
|
||
| **Often null for:** users, institutions, meetings, collections, search, discover, and any page without `osf:type`. That is expected if those types are out of scope for the metric. |
Contributor
There was a problem hiding this comment.
Users could have a type of user. Might be useful since they are also a guid-resolvable resource.
brianjgeiger
approved these changes
Sep 3, 2026
nsemets
force-pushed
the
feat/ENG-12064
branch
from
September 3, 2026 15:36
5c1b643 to
74412e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes