Refactor (packages/ui/src/v2/components/select-v2.tsx): Function with high complexity: SelectV2 - #105
Open
nyonas-ny wants to merge 2 commits into
Open
Refactor (packages/ui/src/v2/components/select-v2.tsx): Function with high complexity: SelectV2#105nyonas-ny wants to merge 2 commits into
nyonas-ny wants to merge 2 commits into
Conversation
Splits createHighlightTracker, normalizeSelectValue, and formatSelectedValue into select-v2-helpers.ts, and extracts the itemComponent render prop into SelectItemV2. Addresses Qlty's high-complexity smell (count=33) on SelectV2. Adds select-v2-helpers.test.ts covering all extracted logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1B: Starter Task: Refactoring PR
Use this pull request template to briefly answer the questions below in one to two sentences each.
Feel free to delete this text at the top after filling out the template.
1. Issue
Link to the associated GitHub issue:
#74
Full path to the refactored file:
(packages/ui/src/v2/components/select-v2.tsx)
What do you think this file does?
(Your answer does not have to be 100% correct; give a reasonable, evidence‑based guess.)
It deals with item rendering and callbacks.
What is the scope of your refactoring within that file?
(Name specific functions/blocks/regions touched.)
I pulled logic out of the SelectV2 function and moved teh drop down rendering into its own component
Which Qlty‑reported issue did you address?
(Name the rule/metric and include the BEFORE value; e.g., “Cognitive Complexity 18 in render()”.)
Function with high complexity (count = 33): SelectV2
2. Refactoring
How did the specific issue you chose impact the codebase’s maintainability?
Everything was crammed into one function, so it was hard to change around the function without understanding what it did.
What changes did you make to resolve the issue?
I split the function into 4 smaller functions, with 3 helper functions in a new file.
How do your changes improve maintainability? Did you consider alternatives?
Each piece can now be read, changed, and tested on its own without having to spend lots of time understanding one giant code block
3. Validation
How did you validate that the change is correct?
Wrote 16 unit tests for the three extracted functions and ran the entire test suite for that package.
Attach a screenshot of the test coverage showing the lines were executed by the tests.
Attach a screenshot showing the tests that cover the change passing during CI
Attach a screenshot of
qlty smells --no-snippets <full/path/to/file.ts>showing fewer reported issues after the changes.Before:
After:
