Feature - #102
Open
jku0227 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1B: Starter Task: Refactoring PR
1. Issue
Link to the associated GitHub issue:
#86
Full path to the refactored file:
packages/core/src/plugin/provider/amazon-bedrock.tsWhat do you think this file does?
(Your answer does not have to be 100% correct; give a reasonable, evidence‑based guess.)
Registers the Amazon Bedrock provider plugin
What is the scope of your refactoring within that file?
(Name specific functions/blocks/regions touched.)
Only
resolveModelIDand the constants above it.Which Qlty‑reported issue did you address?
(Name the rule/metric and include the BEFORE value; e.g., “Cognitive Complexity 18 in render()”.)
Function with many returns (count = 7): resolveModelID2. Refactoring
How did the specific issue you chose impact the codebase’s maintainability?
There were seven returns inside nested ifs + inline model/region lists which made the code hard to follow and easy to break when adding a new region.
What changes did you make to resolve the issue?
Split the region-specific branching out of resolveModelID into three small resolvers,
usPrefix,euPrefix, andapPrefix, each returning a prefix orundefined, and selected between them with aPREFIX_RESOLVERSlookup. Also replaced the four repeatedlist.some((item) => value.includes(item))calls with a singlematchesAnyhelper.How do your changes improve maintainability? Did you consider alternatives?
Each region's rule is now a 2-3 line function, and adding a region is one resolver + one table entry rather than another nested block and return. I considered a
switchon the region prefix but it still left four returns with all the logic in one function.3. Validation
How did you validate that the change is correct?


Attach a screenshot of the test coverage showing the lines were executed by the tests.

Attach a screenshot showing the tests that cover the change passing during CI

Attach a screenshot of


qlty smells --no-snippets <full/path/to/file.ts>showing fewer reported issues after the changes.