Skip to content

[Trigger,PWGEM] Fix includes - #17786

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-EventFiltering
Sep 7, 2026
Merged

[Trigger,PWGEM] Fix includes#17786
dsekihat merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-EventFiltering

Conversation

@vkucera

@vkucera vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 3 errors, ⚠️ 45 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix includes [Trigger,PWGEM] Fix includes Sep 5, 2026
@vkucera
vkucera force-pushed the iwyu-EventFiltering branch from 4780597 to f6e61e2 Compare September 6, 2026 14:25
@vkucera
vkucera marked this pull request as ready for review September 6, 2026 14:28
@vkucera
vkucera force-pushed the iwyu-EventFiltering branch from f6e61e2 to 4109905 Compare September 6, 2026 14:39
@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f6e61e2 at 2026-09-06 17:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 4 warnings.'
Found 6 errors and 4 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/1c92757161060ca5f9436a34e182f3d58be93ae3/O2Physics-code-check/errors.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:62:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:206:24: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:441:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:628:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:710:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:716:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/1c92757161060ca5f9436a34e182f3d58be93ae3/O2Physics-code-check/warnings.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:60:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
EventFiltering/PWGEM/globalDimuonFilter.cxx:204:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
EventFiltering/PWGEM/globalDimuonFilter.cxx:205:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
EventFiltering/PWGEM/globalDimuonFilter.cxx:392:9: warning: do not use 'else' after 'return' [readability-else-after-return]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4109905 at 2026-09-06 17:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 4 warnings.'
Found 6 errors and 4 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/7aeb2b8411aaefcfdc46a94f07cb29e7be477ffe/O2Physics-code-check/errors.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:62:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:206:24: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:441:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:628:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:710:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
EventFiltering/PWGEM/globalDimuonFilter.cxx:716:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/7aeb2b8411aaefcfdc46a94f07cb29e7be477ffe/O2Physics-code-check/warnings.txt
EventFiltering/PWGEM/globalDimuonFilter.cxx:60:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
EventFiltering/PWGEM/globalDimuonFilter.cxx:204:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
EventFiltering/PWGEM/globalDimuonFilter.cxx:205:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
EventFiltering/PWGEM/globalDimuonFilter.cxx:392:9: warning: do not use 'else' after 'return' [readability-else-after-return]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat
dsekihat merged commit b05428d into AliceO2Group:master Sep 7, 2026
11 of 14 checks passed
@vkucera
vkucera deleted the iwyu-EventFiltering branch September 7, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants