Skip to content

[PWGLF,PWGMM] Use const& and std::move to avoid copies - #17712

Open
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:const-PWGMM
Open

[PWGLF,PWGMM] Use const& and std::move to avoid copies#17712
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:const-PWGMM

Conversation

@vkucera

@vkucera vkucera commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Mostly done automatically by Clang-Tidy.

Mostly done automatically by Clang-Tidy.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Use const& and std::move to avoid copies [PWGLF,PWGMM] Use const& and std::move to avoid copies Sep 1, 2026
@vkucera
vkucera marked this pull request as ready for review September 1, 2026 15:54
@alibuild

alibuild commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 30b4ab9 at 2026-09-02 03:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 19 errors and 29 warnings.'
Found 19 errors and 29 warnings.
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/be055204f922f00f4565339e6475b5a5588c931a/O2Physics-code-check/errors.txt
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:248:32: error: variable 'recoVtxX' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:249:32: error: variable 'recoVtxY' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:250:32: error: variable 'recoVtxZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:251:32: error: variable 'recoMultiplicity' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:252:32: error: variable 'recoNumContrib' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:253:32: error: variable 'recoMcCollisionId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:254:32: error: variable 'recoMcCollBestCollisionIndex' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:256:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:938:39: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:939:23: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1206:7: error: uninitialized record type: 'dcaInfOrig' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1322:7: error: uninitialized record type: 'dcaInfOrig' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1409:34: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1410:40: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1411:39: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1709:7: error: uninitialized record type: 'dcaInfOrig' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1796:34: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1797:40: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:1798:39: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 29 -gt 0 ]]
++ cat /sw/BUILD/be055204f922f00f4565339e6475b5a5588c931a/O2Physics-code-check/warnings.txt
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:244:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:245:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:246:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:247:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:332:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:423:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:435:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:449:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:460:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:521:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:532:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:543:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:554:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:567:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:632:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:643:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:654:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:665:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:678:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:703:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/Mult/Tasks/mftReassociationValidation.cxx:741:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants