Skip to content

[PWGHF] Add check for ml output size for Dplus in HfDataCreatorCharmHadPiReduced - #17697

Merged
stefanopolitano merged 1 commit into
AliceO2Group:masterfrom
fchinu:fix_pdg_type
Sep 1, 2026
Merged

[PWGHF] Add check for ml output size for Dplus in HfDataCreatorCharmHadPiReduced#17697
stefanopolitano merged 1 commit into
AliceO2Group:masterfrom
fchinu:fix_pdg_type

Conversation

@fchinu

@fchinu fchinu commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

@github-actions github-actions Bot changed the title Add check for ml output size for Dplus in HfDataCreatorCharmHadPiReduced [PWGHF] Add check for ml output size for Dplus in HfDataCreatorCharmHadPiReduced Sep 1, 2026
@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7bbc9a5 at 2026-09-01 17:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 30 warnings.'
Found 3 errors and 30 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/bdd7bf5c40b747a53c3e9612b340bd21c8e4f945/O2Physics-code-check/errors.txt
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:196:78: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:491:50: error: the parameter 'selectedTracksPion' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:1450:16: error: the variable 'trackSoftPion' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/bdd7bf5c40b747a53c3e9612b340bd21c8e4f945/O2Physics-code-check/warnings.txt
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:283:38: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:283:60: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:283:88: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:283:118: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:283:153: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:283:173: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:284:38: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:284:57: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:284:82: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:284:109: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:284:141: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:284:158: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:285:38: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:285:57: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:285:82: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:285:109: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:285:141: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:285:158: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:286:38: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:286:57: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:286:82: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:286:99: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:287:38: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:287:60: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:287:88: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:287:118: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:287:153: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:287:173: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:344:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx:1317:33: warning: use 'contains' to check for membership [readability-container-contains]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@stefanopolitano
stefanopolitano merged commit 0f67c3b into AliceO2Group:master Sep 1, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants