Skip to content

[Common] Change log level from info to debug for VDrift update #17696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romainschotter wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

[Common] Change log level from info to debug for VDrift update #17696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f080bb
Change log level from info to debug for VDrift update
romainschotter Sep 1, 2026
121b294
dummy commit to restart CI
romainschotter Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Common/Core/TPCVDriftManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
return;
}

// Update Obj
// Update Object
mVD = mCCDB->getForTimeStamp<o2::tpc::VDriftCorrFact>("TPC/Calib/VDriftTgl", timestamp);
if (mVD == nullptr || mVD->firstTime < 0 || mVD->lastTime < 0) {
LOGP(error, "Got invalid VDriftCorrFact for {}", timestamp);
Expand All @@ -60,7 +60,7 @@
mTPCVDriftNS = mVD->refVDrift * mVD->corrFact * 1e-3;

mValid = true;
LOGP(info, "Updated VDrift for timestamp {} with vdrift={:.7f} (cm/ns)", mVD->creationTime, mTPCVDriftNS);
LOGP(debug, "Updated VDrift for timestamp {} with vdrift={:.7f} (cm/ns)", mVD->creationTime, mTPCVDriftNS);
}

template <typename BCs, typename Collisions, typename Collision, typename TrackExtra, typename Track>
Expand Down Expand Up @@ -115,7 +115,7 @@
float dTime = tTB - trackExtra.trackTime();
float dDrift = dTime * mTPCVDriftNS;
float dDriftErr = tTBErr * mTPCVDriftNS;
if (dDriftErr < 0.f || dDrift > 250.f) { // we cannot move a track outside the drift volume

Check failure on line 118 in Common/Core/TPCVDriftManager.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (mOutside < mWarningLimit) {
LOGP(warn, "Skipping correction outside of tpc volume with dDrift={} +- {}", dDrift, dDriftErr);
const auto trackBC = trackExtra.template collision_as<Collisions>().template foundBC_as<BCs>().globalBC();
Expand Down
Loading