Skip to content

[Common] Fill MC hists in a loop over MC collisions in CentralityQa - #17685

Open
romainschotter wants to merge 4 commits into
masterfrom
romainschotter-patch-3
Open

[Common] Fill MC hists in a loop over MC collisions in CentralityQa#17685
romainschotter wants to merge 4 commits into
masterfrom
romainschotter-patch-3

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator
  • Add option to loop over MC collisions to fill MC histograms, while before all MC histograms were filled in a loop over reconstructed collisions

@github-actions github-actions Bot changed the title Fill MC hists in a loop over MC collisions in CentralityQa [Common] Fill MC hists in a loop over MC collisions in CentralityQa Aug 31, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 25 warnings, 🔕 0 disabled

@romainschotter
romainschotter marked this pull request as ready for review August 31, 2026 16:14
Changed default value of loopOverMcCollisionsForMcHist from true to false.
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d454833 at 2026-08-31 20:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/ed84201d914a9c9e397dd0c5ce33eae0ca1fa71d/O2Physics-code-check/errors.txt
Common/Tasks/centralityQa.cxx:1437:13: error: variable 'nContribsInEta05' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
Common/Tasks/centralityQa.cxx:1449:13: error: Value stored to 'nContribsInEta05' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants