Skip to content

[PWGLF] MC now has direct link between generated and reco. - #17682

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
lietava:omegahm
Aug 31, 2026
Merged

[PWGLF] MC now has direct link between generated and reco.#17682
romainschotter merged 1 commit into
AliceO2Group:masterfrom
lietava:omegahm

Conversation

@lietava

@lietava lietava commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Trying to do correction as function of fCentFT0M.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 45 errors, ⚠️ 16 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title MC now has direct link between generated and reco. [PWGLF] MC now has direct link between generated and reco. Aug 31, 2026
@lietava
lietava marked this pull request as ready for review August 31, 2026 14:47
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bfcd443 at 2026-08-31 17:18:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 31 warnings.'
Found 8 errors and 31 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/17b91748ddfcaaad8783691a56b46472071c9b4c/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:183:30: error: variable 'gCandidates' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:184:30: error: variable 'gCandidatesNT' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:188:8: error: constructor does not initialize these fields: mCCDB, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:228:69: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:301:21: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:302:24: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:527:7: error: uninitialized record type: 'momenta' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:528:7: error: uninitialized record type: 'cascadeMomentum' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 31 -gt 0 ]]
++ cat /sw/BUILD/17b91748ddfcaaad8783691a56b46472071c9b4c/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:171:22: warning: 'nParticles' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:172:22: warning: 'nCutsPID' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:173:39: warning: 'matterOrNot' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:174:39: warning: 'particlesNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:175:39: warning: 'cutsNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:176:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:176:24: warning: 'cutsPID' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:263:9: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:492:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:638:71: warning: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:650:19: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:857:11: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1007:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1033:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1033:49: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1077:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1086:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1097:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1105:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1124:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1135:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1150:12: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1164:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1174:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1195:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1209:22: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1217:23: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1219:23: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1265:22: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1273:23: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1275:23: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
++ [[ 8 -gt 0 ]]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit a4cfb3f into AliceO2Group:master Aug 31, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants