Fix join_into overwriting a destination that holds the source - #116
Merged
luketpeterson merged 2 commits intoSep 19, 2026
Merged
Conversation
Joining with a TinyRefNode swapped operands without inverting the identity mask, so an unchanged destination reported COUNTER_IDENT and join_into replaced it with the source. merge_guts and the integer pjoin also under-reported identities, giving Element for unchanged joins. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019R2H8fnco29asY2v3TPbtF
# Conflicts: # src/write_zipper.rs
Collaborator
|
3 fixes in here. 2 of them are very good (carrying status through merge_guts, and the dispatch to tiny_node). The third is harmless (changing policy on trash Lattice impls). Merging because I don't care enough to break out the third fix into a separate PR if it's going to get merged anyway. And I figured there must be a reason behind the change and don't really care enough to fight about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joining with a TinyRefNode swapped operands without inverting the identity mask, so an unchanged destination reported COUNTER_IDENT and join_into replaced it with the source. merge_guts and the integer pjoin also under-reported identities, giving Element for unchanged joins.