Arms slayer_st APL bug

[polievkt]

Describe the bug

I think there may be a bug in the current Arms APL

actions.slayer_st+=/execute,if=buff.sudden_death.stack=2|cooldown.bladestorm.ready&(!buff.imminent_demise.stack=1|!buff.imminent_demise.stack=3)

Looks like it is intended to use Execute before a Bladestorm when Imminent Demise is not at 1 or 3 stacks — i.e. at 0 or 2 stacks. That would make sense with Unhinged, since going 0 to 1 or 2 to 3 adds an extra Unhinged Mortal

However, because ! has higher priority than =, I believe !buff.imminent_demise.stack=1 is parsed as (!buff.imminent_demise.stack)=1 rather than !(buff.imminent_demise.stack=1)

As a result, the second part of the condition effectively only succeeds at 0 Imminent Demise stacks, and the 2 to 3 case is missed

Expected behavior

If the intended logic is "Execute when Bladestorm is ready and Imminent Demise is 0 or 2", I think this should be written as either:

cooldown.bladestorm.ready&(buff.imminent_demise.stack=0|buff.imminent_demise.stack=2)

or:

cooldown.bladestorm.ready&!(buff.imminent_demise.stack=1|buff.imminent_demise.stack=3)

[yapsixebaniy546]

I also wanted to write about this error, but I saw you, thank you.

[yapsixebaniy546]

I just didn't understand one thing, in the guides it says what to use when stacks are <3, and in the code at 0 and 2

If you follow the guide to vovhead, then this is the correct option: actions.slayer_st+=/execute,if=buff.sudden_death.stack=2|cooldown.bladestorm.ready&(buff.imminent_demise.stack<3)