From 6d7ba570271183abef72cd105506e6381fe66b13 Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Sat, 5 Sep 2026 10:18:42 +0100 Subject: [PATCH 1/2] Fix combined builds missing HTML output --- build_docs.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/build_docs.py b/build_docs.py index eb304b6..3720e54 100755 --- a/build_docs.py +++ b/build_docs.py @@ -756,8 +756,14 @@ def build(self) -> None: else: maketarget = "autobuild-stable" if self.html_only: - maketarget += "-html" - logging.info("Running make %s", maketarget) + maketargets = [f"{maketarget}-html"] + else: + maketargets = [maketarget] + if self.includes_html and self.build_meta.version_tuple >= (3, 9): + # Since 3.9, the plain autobuild targets only build non-HTML + # (gh-139436), but a combined build needs HTML. + maketargets.append(f"{maketarget}-html") + logging.info("Running make %s", " ".join(maketargets)) python = self.venv / "bin" / "python" sphinxbuild = self.venv / "bin" / "sphinx-build" blurb = self.venv / "bin" / "blurb" @@ -792,7 +798,7 @@ def build(self) -> None: f"VENVDIR={self.venv}", f"SPHINXOPTS={' '.join(sphinxopts)}", "SPHINXERRORHANDLING=", - maketarget, + *maketargets, )) self.log_directory.mkdir(parents=True, exist_ok=True) chgrp(self.log_directory, group=self.group, recursive=True) From b68ff5616999683ee4b6df7f0353face87b66ede Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Sat, 5 Sep 2026 15:05:30 +0100 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> --- build_docs.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build_docs.py b/build_docs.py index 3720e54..384f222 100755 --- a/build_docs.py +++ b/build_docs.py @@ -759,8 +759,8 @@ def build(self) -> None: maketargets = [f"{maketarget}-html"] else: maketargets = [maketarget] - if self.includes_html and self.build_meta.version_tuple >= (3, 9): - # Since 3.9, the plain autobuild targets only build non-HTML + if self.includes_html: + # The plain autobuild targets only build non-HTML # (gh-139436), but a combined build needs HTML. maketargets.append(f"{maketarget}-html") logging.info("Running make %s", " ".join(maketargets))