Skip to content

CRITICAL: No page type validation on read #150

Description

@poyrazK

Why is this an issue?

In src/storage/buffer_pool_manager.cpp:44-48:

if (!file || !storage_.read_page(...)) {
    return nullptr;
}
// No validation that page_type matches expected!

Corrupted or wrong-type pages accepted without detection.

What is causing it?

Missing page type validation.

How can it be solved?

Validate page_type header on read.

Category

  • Small
  • Medium
  • Large
  • Critical

Severity

  • Low
  • Medium
  • High
  • Critical

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions