Testing: version 2.2

[zerocrates]

Master branch, which is the prospective version 2.2.

This release does a significant change to how the tree works internally, getting rid of a separate copy of the collection title the plugin previously stored. This should fix #35, and otherwise function as before.

[allanaaa]

Sorting the collection tree alphabetically only applies to the topmost level, and not the sublevels:

[allanaaa]

And I'm getting a number of errors when the "Browse root-level collections only" setting is checked:

[allanaaa]

Actually, alphabetical sorting works on sublevels when the "Browse root-level collections only" is unchecked:

Though I wonder if you could filter out formatting so the italicized ones aren't coming in separately from the plain ones?

[zerocrates]

I'm not sure if we can mess with the order like that, but I'll look at what we're doing.

So clearly there's some issues with the "root only" option, I'll see what's up there.

[zerocrates]

OK I think pulling should resolve the issues with "Browse root-level collections only"

[zerocrates]

On the styling messing with the order, we're using the database order, and the database doesn't have a "no styling" version to sort on so I don't think we can do anything there. The order should be consistent with how it works without the plugin.

[allanaaa]

1. I made a child collection private and that disappeared all its items too, including from the parent-level browse if "Show subcollection items" is checked. Could they show up in the parent collection, if the items are public and the parent collection is public but the child collection is private?

2. I made a parent collection private and it disappeared all its children collections and all their items. Navigating directly to a public child collection gave me:

https://dev.omeka.org/amayer/amayer-c/omeka/collections/show/344
is a public collection with a private parent.

That collection is available from the browse page when the "root-level" setting is unchecked, and unavailable when checked (rightly).

Other than the error messages, I wonder if the public children collections of a private parent should just show back up in the collection tree as root collections when that happens? Which would change the former behaviour.

[zerocrates]

I'm skittish about pulling in the items into the parent if there's a private collection somewhere in the tree on the way down to them... I don't know for sure what the user expectation there is so I'd err on being conservative.

I probably feel the same about showing the tree from the perspective of a public child of a private collection... showing the tree as configured with the "[Unavailable]" is probably the safest move vs. guessing that they want this at the root?

The warnings of course should get fixed.

[allanaaa]

Okay! I'll update the manual with more information about visibility.

[zerocrates]

OK latest pull should fix the warnings

[allanaaa]

Looks great. If you would review the new docs section at the end of the page quickly, I think we're done here.

[zerocrates]

Looks good to me. Maybe add "if you have private collections" to that last sentence about how it will look different for the general public.