Problem
Inactive tiles are treated inconsistently after a player has already marked one. The player board and loadStandings count completed.has(tile.id) regardless of isActive, but the admin review loadBingoState explicitly skips every inactive tile before detecting bingo.
Consequently, if an administrator locks a tile after players marked it, a player can still see a winning line while the administrator sees no bingo and cannot verify it. The leaderboard uses the player behavior rather than the review behavior.
Reproduction
- Let a player mark a tile that is part of a potential winning row.
- In
/admin/tiles, change that tile to inactive.
- Complete the rest of that row.
- The player board counts the old mark and can show BINGO, but
/admin/users/:id omits it from detection and the verify action rejects the claim.
Suggested fix
Choose and document one policy for progress on locked tiles. If old progress remains valid, remove the !t.isActive skip from admin detection. If locking is meant to invalidate progress, apply the same rule in the player board and standings, and address verification/reset state consistently.
Affected code
src/routes/bingo/+page.server.ts
src/routes/admin/users/[id]/+page.server.ts
src/lib/server/standings.ts
Problem
Inactive tiles are treated inconsistently after a player has already marked one. The player board and
loadStandingscountcompleted.has(tile.id)regardless ofisActive, but the admin reviewloadBingoStateexplicitly skips every inactive tile before detecting bingo.Consequently, if an administrator locks a tile after players marked it, a player can still see a winning line while the administrator sees no bingo and cannot verify it. The leaderboard uses the player behavior rather than the review behavior.
Reproduction
/admin/tiles, change that tile to inactive./admin/users/:idomits it from detection and the verify action rejects the claim.Suggested fix
Choose and document one policy for progress on locked tiles. If old progress remains valid, remove the
!t.isActiveskip from admin detection. If locking is meant to invalidate progress, apply the same rule in the player board and standings, and address verification/reset state consistently.Affected code
src/routes/bingo/+page.server.tssrc/routes/admin/users/[id]/+page.server.tssrc/lib/server/standings.ts