[bot] Merge master/3ad5eca2 into rel/dev - #1777
Merged
Merged
Conversation
…_detail Addresses hkad98's PR #1750 review comment: the per-turn subset reported in detail["turns"] was a bare dict literal with no type checking. TurnDetail mirrors the same 6 fields; asdict() at the boundary keeps the output shape (and the detail: dict contract) unchanged.
Per hkad98's review comment on #1757: replace the separate TurnDetail dataclass + _conversation_detail's asdict() call with a detail() method on TurnResult itself, since it already owns every field being reported. Output shape (detail["turns"]) is unchanged.
….detail() detail() returned self.activated_skills directly -- a caller mutating the returned dict could mutate the TurnResult it came from. Caught by CodeRabbit on PR #1757.
…ot a key list Addresses hkad98's review: TurnResult is already a pydantic BaseModel, so a hand-written dict literal of six of its own field names was a second copy to keep in sync. detail() now returns model_dump(include=_DETAIL_FIELDS). Two things fall out of it: - A field rename can no longer leave detail() emitting a stale key with no test failure -- include= raises on a name the model doesn't have, and a new test asserts _DETAIL_FIELDS is a subset of model_fields. - model_dump deep-copies activated_skills, so the explicit list() wrapper is no longer needed; the copy regression test still passes. Also renames the copy test to test_turn_result_detail_copies_activated_skills (the previous 71-character name restated its own docstring) and lifts the shared TurnResult construction into a helper.
…ataclass Return the per-turn detail subset from TurnResult
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1777 +/- ##
========================================
Coverage 81.59% 81.59%
========================================
Files 275 275
Lines 19848 19851 +3
========================================
+ Hits 16194 16197 +3
Misses 3654 3654 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 3ad5eca (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/33851475927).