Skip to content

UpServer tries to reload twice in a row and fails #52

Description

@accerqueira

The command line I use was:
node node_modules/up/bin/up -p 9400 -w server

After I touched a file, the following happens:

  up-cli /home/accerqueira/experiments/server/server.js change detected - reloading
  up reloading - spawning 2 new workers
  up spawning 2 workers from master 8738
  up worker 8745 created
  up worker 8746 created
  up-cli /home/accerqueira/experiments/server/server.js change detected - reloading
  up killing spawning worker 8745

/home/accerqueira/experiments/server/node_modules/up/lib/up.js:127
    this.spawning[i].shutdown();
                     ^
TypeError: Cannot call method 'shutdown' of undefined
    at UpServer.reload (/home/accerqueira/experiments/gg-web/node_modules/up/lib/up.js:127:22)
    at /home/accerqueira/experiments/gg-web/node_modules/up/bin/up:288:9
    at FSWatcher.<anonymous> (/home/accerqueira/experiments/gg-web/node_modules/up/bin/up:275:9)
    at FSWatcher.emit (events.js:70:17)
    at FSEvent.onchange (fs.js:665:12)

I'm using 15e82c6, traced the error back to dc4e57e, when it was working, but I could fix by reverting 2 lines from 6ad3f6b.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions