diff --git a/PWGLF/TableProducer/Common/epvector.cxx b/PWGLF/TableProducer/Common/epvector.cxx index a001de0407f..99e401b67d8 100644 --- a/PWGLF/TableProducer/Common/epvector.cxx +++ b/PWGLF/TableProducer/Common/epvector.cxx @@ -210,7 +210,7 @@ struct epvector { } template - bool eventSelected(TCollision collision, const float& centrality) + bool eventSelected(const TCollision& collision, const float& centrality) { if (collision.alias_bit(kTVXinTRD)) { // TRD triggered // return 0; diff --git a/PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx b/PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx index a62030fc507..7e26c4ae356 100644 --- a/PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx +++ b/PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx @@ -355,7 +355,7 @@ struct DeuteronInTriggeredEvents { HistogramRegistry spectra{"spectra", {}, OutputObjHandlingPolicy::AnalysisObject, true, true}; - double computeAbsoDecL(aod::McParticles::iterator particle) + double computeAbsoDecL(const aod::McParticles::iterator& particle) { if (!particle.has_daughters()) return -1.f; diff --git a/PWGLF/TableProducer/Nuspex/hypKfRecoTask.cxx b/PWGLF/TableProducer/Nuspex/hypKfRecoTask.cxx index 7755a77bc8a..43bb58a3f2f 100644 --- a/PWGLF/TableProducer/Nuspex/hypKfRecoTask.cxx +++ b/PWGLF/TableProducer/Nuspex/hypKfRecoTask.cxx @@ -198,7 +198,7 @@ struct DaughterParticle { std::array betheParams; std::array trkSettings; bool active; - DaughterParticle(std::string name_, int pdgCode_, double mass_, int charge_, LabeledArray bethe, LabeledArray settings) : name(name_), pdgCode(pdgCode_), charge(charge_), mass(mass_), active(false) + DaughterParticle(const std::string& name_, int pdgCode_, double mass_, int charge_, const LabeledArray& bethe, const LabeledArray& settings) : name(name_), pdgCode(pdgCode_), charge(charge_), mass(mass_), active(false) { for (unsigned int i = 0; i < betheParams.size(); i++) { betheParams[i] = bethe.get(name, i); @@ -220,19 +220,19 @@ struct HyperNucleus { bool active, savePrimary; std::vector daughters, daughterTrackSigns, v0DaughterVec; std::vector primSettings; - HyperNucleus(std::string name_, int pdgCode_, bool active_, std::vector daughters_, std::vector daughterTrackSigns_, std::vector v0DaughterVec_, LabeledArray primSettings_) : pdgCode(pdgCode_), active(active_), savePrimary(active_) + HyperNucleus(const std::string& name_, int pdgCode_, bool active_, const std::vector& daughters_, const std::vector& daughterTrackSigns_, const std::vector& v0DaughterVec_, const LabeledArray& primSettings_) : pdgCode(pdgCode_), active(active_), savePrimary(active_) { - init(name_, daughters_, daughterTrackSigns_, v0DaughterVec_); + init(std::move(name_), std::move(daughters_), std::move(daughterTrackSigns_), std::move(v0DaughterVec_)); for (unsigned int i = 0; i < nSelPrim; i++) { primSettings.push_back(primSettings_.get(name, i)); } } - HyperNucleus(std::string name_, int pdgCode_, bool active_, int hypDaughter, std::vector daughters_, std::vector daughterTrackSigns_) : pdgCode(pdgCode_), active(active_), savePrimary(active_) + HyperNucleus(const std::string& name_, int pdgCode_, bool active_, int hypDaughter, const std::vector& daughters_, const std::vector& daughterTrackSigns_) : pdgCode(pdgCode_), active(active_), savePrimary(active_) { daughters.push_back(hypDaughter); - init(name_, daughters_, daughterTrackSigns_); + init(std::move(name_), std::move(daughters_), std::move(daughterTrackSigns_)); } - void init(std::string name_, std::vector daughters_, std::vector daughterTrackSigns_, std::vector v0DaughterVec_ = {}) + void init(const std::string& name_, const std::vector& daughters_, const std::vector& daughterTrackSigns_, const std::vector& v0DaughterVec_ = {}) { name = TString(name_); for (const int& d : daughters_) @@ -265,8 +265,8 @@ struct DaughterKf { float dcaToPv, dcaToPvXY, dcaToPvZ, tpcNsigma, tpcNsigmaNLP, tpcNsigmaNHP; bool active; std::vector vtx; - DaughterKf(int species_, int64_t daughterTrackId_, int sign_, std::vector vtx_, float tpcNsigma_, float tpcNsigmaNLP_, float tpcNsigmaNHP_) : daughterTrackId(daughterTrackId_), id(uniqueId++), species(species_), sign(sign_), hypNucId(-1), tpcNsigma(tpcNsigma_), tpcNsigmaNLP(tpcNsigmaNLP_), tpcNsigmaNHP(tpcNsigmaNHP_), vtx(vtx_) {} - void addKfp(KFParticle daughterKfp_) + DaughterKf(int species_, int64_t daughterTrackId_, int sign_, std::vector vtx_, float tpcNsigma_, float tpcNsigmaNLP_, float tpcNsigmaNHP_) : daughterTrackId(daughterTrackId_), id(uniqueId++), species(species_), sign(sign_), hypNucId(-1), tpcNsigma(tpcNsigma_), tpcNsigmaNLP(tpcNsigmaNLP_), tpcNsigmaNHP(tpcNsigmaNHP_), vtx(std::move(vtx_)) {} + void addKfp(const KFParticle& daughterKfp_) { daughterKfp = daughterKfp_; dcaToPvXY = daughterKfp.GetDistanceFromVertexXY(&vtx[0]); @@ -290,7 +290,7 @@ struct HyperNucCandidate { bool mcTrue, isPhysPrimary, isPrimaryCandidate, isSecondaryCandidate, isUsedSecondary; int64_t mcParticleId; int tableId; - HyperNucCandidate(int species_, HyperNucCandidate* hypNucDaughter_, std::vector daughters_) : species(species_), hypNucDaughter(hypNucDaughter_), devToPvXY(-999), dcaToPvXY(-999), dcaToPvZ(-999), dcaToVtxXY(-999), dcaToVtxZ(-999), chi2(-999), itsMeanClsSize(-1), mcTrue(false), isPhysPrimary(false), isPrimaryCandidate(false), isSecondaryCandidate(false), isUsedSecondary(false), mcParticleId(-1), tableId(-1) + HyperNucCandidate(int species_, HyperNucCandidate* hypNucDaughter_, const std::vector& daughters_) : species(species_), hypNucDaughter(hypNucDaughter_), devToPvXY(-999), dcaToPvXY(-999), dcaToPvZ(-999), dcaToVtxXY(-999), dcaToVtxZ(-999), chi2(-999), itsMeanClsSize(-1), mcTrue(false), isPhysPrimary(false), isPrimaryCandidate(false), isSecondaryCandidate(false), isUsedSecondary(false), mcParticleId(-1), tableId(-1) { for (const auto& d : daughters_) daughters.push_back(d); @@ -402,7 +402,7 @@ struct HyperNucCandidate { } return calcSubDaughterMass(daughters.at(d1)->daughterKfp, hypNucDaughter->daughters.at(d2)->daughterKfp); } - float calcSubDaughterMass(KFParticle d1, KFParticle d2) + float calcSubDaughterMass(const KFParticle& d1, const KFParticle& d2) { KFParticle subDaughter; subDaughter.SetConstructMethod(2); @@ -475,7 +475,7 @@ struct DaughterCombinations { int nVecs, nCombinations; bool end; std::vector nonV0daughters; - DaughterCombinations(std::vector*>& vecs, std::vector nonV0daughters_) : nVecs(0), nCombinations(1), end(false), nonV0daughters(nonV0daughters_) + DaughterCombinations(std::vector*>& vecs, std::vector nonV0daughters_) : nVecs(0), nCombinations(1), end(false), nonV0daughters(std::move(nonV0daughters_)) { for (const auto& vec : vecs) { nVecs++; @@ -1311,7 +1311,7 @@ struct HypKfRecoTask { } //---------------------------------------------------------------------------------------------------------------- - int getHypDaughterVec(unsigned int cascade, LabeledArray cfg) + int getHypDaughterVec(unsigned int cascade, const LabeledArray& cfg) { std::string daughter = cfg.get(cascade, 0u); if (std::find(hyperNucNames.begin(), hyperNucNames.end(), daughter) == hyperNucNames.end()) @@ -1319,7 +1319,7 @@ struct HypKfRecoTask { return std::find(hyperNucNames.begin(), hyperNucNames.end(), daughter) - hyperNucNames.begin(); } //---------------------------------------------------------------------------------------------------------------- - std::vector getDaughterVec(unsigned int hypNuc, LabeledArray cfg) + std::vector getDaughterVec(unsigned int hypNuc, const LabeledArray& cfg) { std::vector vec; for (unsigned int i = kD1; i <= kD4; i++) { @@ -1332,7 +1332,7 @@ struct HypKfRecoTask { } //---------------------------------------------------------------------------------------------------------------- - std::vector getDaughterSignVec(unsigned int hypNuc, LabeledArray cfg) + std::vector getDaughterSignVec(unsigned int hypNuc, const LabeledArray& cfg) { std::vector vec; std::string signs = cfg.get(hypNuc, "daughterSigns"); @@ -1345,7 +1345,7 @@ struct HypKfRecoTask { return vec; } //---------------------------------------------------------------------------------------------------------------- - std::vector getV0DaughterVec(unsigned int hypNuc, LabeledArray cfg) + std::vector getV0DaughterVec(unsigned int hypNuc, const LabeledArray& cfg) { std::vector vec; std::string v0ds = cfg.get(hypNuc, "useV0for"); diff --git a/PWGLF/TableProducer/Nuspex/hypKfTreeCreator.cxx b/PWGLF/TableProducer/Nuspex/hypKfTreeCreator.cxx index 3a3a2ab3463..f98b707a2c2 100644 --- a/PWGLF/TableProducer/Nuspex/hypKfTreeCreator.cxx +++ b/PWGLF/TableProducer/Nuspex/hypKfTreeCreator.cxx @@ -438,7 +438,7 @@ struct HypKfTreeCreator { PROCESS_SWITCH(HypKfTreeCreator, processMC, "MC tree", false); //___________________________________________________________________________________________________________________________________________________________ - std::vector dcaTracksAll(std::vector& posVec, TString opt = "") + std::vector dcaTracksAll(std::vector& posVec, const TString& opt = "") { std::vector vec; int n = posVec.size(); @@ -450,7 +450,7 @@ struct HypKfTreeCreator { return vec; } template - std::vector dcaTrackSvAll(std::vector& posVec, T const& hypNuc, TString opt = "") + std::vector dcaTrackSvAll(std::vector& posVec, T const& hypNuc, const TString& opt = "") { std::vector vec; for (size_t i = 0; i < posVec.size(); i++) { @@ -463,14 +463,14 @@ struct HypKfTreeCreator { { return *max_element(vec.begin(), vec.end()); } - float meanValue(std::vector vec) + float meanValue(const std::vector& vec) { float sum = 0; for (const auto& value : vec) sum += value; return sum / vec.size(); } - float mean2Value(std::vector vec) + float mean2Value(const std::vector& vec) { float sum = 0; for (const auto& value : vec) @@ -478,7 +478,7 @@ struct HypKfTreeCreator { return std::sqrt(sum / vec.size()); } - float dcaTracks(std::vector v, int track1, int track2, TString opt = "XY") + float dcaTracks(std::vector v, int track1, int track2, const TString& opt = "XY") { if (opt == "XY") return RecoDecay::distanceXY(v.at(track1), v.at(track2)); @@ -488,7 +488,7 @@ struct HypKfTreeCreator { return RecoDecay::distance(v.at(track1), v.at(track2)); } template - float dcaTrackSv(std::vector& v, int track, T const& hypNuc, TString opt = "") + float dcaTrackSv(std::vector& v, int track, T const& hypNuc, const TString& opt = "") { if (opt == "XY") return RecoDecay::distanceXY(v.at(track), decayVtx(hypNuc)); diff --git a/PWGLF/TableProducer/Nuspex/hyperkinkRecoTask.cxx b/PWGLF/TableProducer/Nuspex/hyperkinkRecoTask.cxx index 60af4175db1..cff24b20ee9 100644 --- a/PWGLF/TableProducer/Nuspex/hyperkinkRecoTask.cxx +++ b/PWGLF/TableProducer/Nuspex/hyperkinkRecoTask.cxx @@ -1162,7 +1162,7 @@ struct HyperkinkQa { // QA for mother track selection template - bool motherTrackCheck(const TTrack& track, const std::shared_ptr hist) + bool motherTrackCheck(const TTrack& track, const std::shared_ptr& hist) { hist->Fill(1); @@ -1206,7 +1206,7 @@ struct HyperkinkQa { // qa for daughter track selection template - bool daughterTrackCheck(const TTrack& track, const std::shared_ptr hist, float tpcNSigma) + bool daughterTrackCheck(const TTrack& track, const std::shared_ptr& hist, float tpcNSigma) { hist->Fill(1); diff --git a/PWGLF/TableProducer/Nuspex/nucleiSpectra.cxx b/PWGLF/TableProducer/Nuspex/nucleiSpectra.cxx index 5358f18b079..67837173150 100644 --- a/PWGLF/TableProducer/Nuspex/nucleiSpectra.cxx +++ b/PWGLF/TableProducer/Nuspex/nucleiSpectra.cxx @@ -394,7 +394,7 @@ struct nucleiSpectra { HistogramRegistry spectra{"spectra", {}, OutputObjHandlingPolicy::AnalysisObject, true, true}; - double computeAbsoDecL(aod::McParticles::iterator particle) + double computeAbsoDecL(const aod::McParticles::iterator& particle) { if (!particle.has_daughters()) return -1.f; diff --git a/PWGLF/TableProducer/Nuspex/trackedHypertritonRecoTask.cxx b/PWGLF/TableProducer/Nuspex/trackedHypertritonRecoTask.cxx index 1fddbb346fa..55de811da12 100644 --- a/PWGLF/TableProducer/Nuspex/trackedHypertritonRecoTask.cxx +++ b/PWGLF/TableProducer/Nuspex/trackedHypertritonRecoTask.cxx @@ -780,7 +780,7 @@ struct TrackedHypertritonRecoTask { } template - std::array getItsTrackDCAToSV(TTracked3body tracked3Body) + std::array getItsTrackDCAToSV(const TTracked3body& tracked3Body) { const auto itsTrack = tracked3Body.template itsTrack_as(); auto itsTrackParCov = getTrackParCov(itsTrack); diff --git a/PWGLF/TableProducer/Resonances/HeptaQuarktable.cxx b/PWGLF/TableProducer/Resonances/HeptaQuarktable.cxx index 3171b1c93dd..3516949aa9c 100644 --- a/PWGLF/TableProducer/Resonances/HeptaQuarktable.cxx +++ b/PWGLF/TableProducer/Resonances/HeptaQuarktable.cxx @@ -262,7 +262,7 @@ struct heptaquarktable { auto posThisColl = posTracks->sliceByCached(aod::track::collisionId, collision.globalIndex(), cache); auto negThisColl = negTracks->sliceByCached(aod::track::collisionId, collision.globalIndex(), cache); - for (auto track1 : posThisColl) { + for (const auto& track1 : posThisColl) { if (!selectionTrack(track1)) continue; @@ -279,7 +279,7 @@ struct heptaquarktable { } */ auto track1ID = track1.globalIndex(); - for (auto track2 : negThisColl) { + for (const auto& track2 : negThisColl) { if (!selectionTrack(track2)) continue; diff --git a/PWGLF/TableProducer/Resonances/doublephitable.cxx b/PWGLF/TableProducer/Resonances/doublephitable.cxx index 2e04cd9be96..7845dbdf6b3 100644 --- a/PWGLF/TableProducer/Resonances/doublephitable.cxx +++ b/PWGLF/TableProducer/Resonances/doublephitable.cxx @@ -264,7 +264,7 @@ struct doublephitable { hProcessedEvents->Fill(2.5); auto posThisColl = posTracks->sliceByCached(aod::track::collisionId, collision.globalIndex(), cache); auto negThisColl = negTracks->sliceByCached(aod::track::collisionId, collision.globalIndex(), cache); - for (auto track1 : posThisColl) { + for (const auto& track1 : posThisColl) { // track selection if (!selectionTrack(track1)) { continue; @@ -283,7 +283,7 @@ struct doublephitable { qaRegistry.fill(HIST("hNsigmaPtkaonTOF"), track1.tofNSigmaKa(), track1.pt()); } auto track1ID = track1.globalIndex(); - for (auto track2 : negThisColl) { + for (const auto& track2 : negThisColl) { auto track2ID = track2.globalIndex(); if (track2ID == track1ID) { continue; @@ -600,7 +600,7 @@ struct doublephitable { selectedNeg.reserve(negThisColl.size()); selectedPosITS.reserve(posThisColl.size()); selectedNegITS.reserve(negThisColl.size()); - for (auto track : posThisColl) { + for (const auto& track : posThisColl) { if (!selectionTrack(track)) { continue; } @@ -622,7 +622,7 @@ struct doublephitable { } } - for (auto track : negThisColl) { + for (const auto& track : negThisColl) { if (!selectionTrack(track)) { continue; } diff --git a/PWGLF/TableProducer/Resonances/f1protonInitializer.cxx b/PWGLF/TableProducer/Resonances/f1protonInitializer.cxx index 5c52b6ca4d3..4ec94e32a03 100644 --- a/PWGLF/TableProducer/Resonances/f1protonInitializer.cxx +++ b/PWGLF/TableProducer/Resonances/f1protonInitializer.cxx @@ -222,7 +222,7 @@ struct f1protoninitializer { bool triggerF1 = false; bool triggerF1Proton = false; bool triggerF1ProtonFemto = false; - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!SelectionTrack(track1)) { continue; } @@ -242,7 +242,7 @@ struct f1protoninitializer { qaRegistry.fill(HIST("hNsigmaPtpionTOF"), track1.tofNSigmaPi(), track1.pt()); } auto track1ID = track1.globalIndex(); - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!SelectionTrack(track2)) { continue; } @@ -273,7 +273,7 @@ struct f1protoninitializer { int track2Sign = track2.sign(); numberPiKpair = numberPiKpair + 1; - for (auto track3 : V0s) { + for (const auto& track3 : V0s) { if (!SelectionV0(collision, track3)) { continue; } @@ -308,7 +308,7 @@ struct f1protoninitializer { F1Vector.SetXYZM(track1.px() + track2.px() + track3.px(), track1.py() + track2.py() + track3.py(), track1.pz() + track2.pz() + track3.pz(), massF1); ////////////// proton loop for F1-proton trigger///////////////// - for (auto track4 : tracks) { + for (const auto& track4 : tracks) { auto collisionId4 = track4.collisionId(); if (collisionId1 != collisionId4) { continue; diff --git a/PWGLF/TableProducer/Resonances/f1protonreducedtable.cxx b/PWGLF/TableProducer/Resonances/f1protonreducedtable.cxx index 44ce411c9eb..e64210a9ec7 100644 --- a/PWGLF/TableProducer/Resonances/f1protonreducedtable.cxx +++ b/PWGLF/TableProducer/Resonances/f1protonreducedtable.cxx @@ -355,7 +355,7 @@ struct f1protonreducedtable { return false; } - inline bool passProtonPID(float nsigmaTPC, float nsigmaTOF, float TOFHit, ROOT::Math::PtEtaPhiMVector proton) + inline bool passProtonPID(float nsigmaTPC, float nsigmaTOF, float TOFHit, const ROOT::Math::PtEtaPhiMVector& proton) { // pidMode: // 0 = default: p < thr -> |TPC| < 2.5 ; p >= thr -> TOF mandatory AND circular(TPC,TOF) < 2.0 @@ -424,8 +424,8 @@ struct f1protonreducedtable { return true; } - float getkstar(const ROOT::Math::PtEtaPhiMVector part1, - const ROOT::Math::PtEtaPhiMVector part2) + float getkstar(const ROOT::Math::PtEtaPhiMVector& part1, + const ROOT::Math::PtEtaPhiMVector& part2) { const ROOT::Math::PtEtaPhiMVector trackSum = part1 + part2; const float beta = trackSum.Beta(); @@ -444,7 +444,7 @@ struct f1protonreducedtable { return 0.5 * trackRelK.P(); } - std::vector setValuesBB(o2::ccdb::CcdbApi& ccdbApi, aod::BCsWithTimestamps::iterator const& bunchCrossing, const std::string ccdbPath) + std::vector setValuesBB(o2::ccdb::CcdbApi& ccdbApi, aod::BCsWithTimestamps::iterator const& bunchCrossing, const std::string& ccdbPath) { std::map metadata; auto h = ccdbApi.retrieveFromTFileAny(ccdbPath, metadata, bunchCrossing.timestamp()); diff --git a/PWGLF/TableProducer/Resonances/filterf1proton.cxx b/PWGLF/TableProducer/Resonances/filterf1proton.cxx index c9f56828434..995cd37c504 100644 --- a/PWGLF/TableProducer/Resonances/filterf1proton.cxx +++ b/PWGLF/TableProducer/Resonances/filterf1proton.cxx @@ -355,8 +355,8 @@ struct filterf1proton { return true; } - float getkstar(const ROOT::Math::PtEtaPhiMVector part1, - const ROOT::Math::PtEtaPhiMVector part2) + float getkstar(const ROOT::Math::PtEtaPhiMVector& part1, + const ROOT::Math::PtEtaPhiMVector& part2) { const ROOT::Math::PtEtaPhiMVector trackSum = part1 + part2; const float beta = trackSum.Beta(); @@ -375,7 +375,7 @@ struct filterf1proton { return 0.5 * trackRelK.P(); } - std::vector setValuesBB(o2::ccdb::CcdbApi& ccdbApi, aod::BCsWithTimestamps::iterator const& bunchCrossing, const std::string ccdbPath) + std::vector setValuesBB(o2::ccdb::CcdbApi& ccdbApi, aod::BCsWithTimestamps::iterator const& bunchCrossing, const std::string& ccdbPath) { std::map metadata; auto h = ccdbApi.retrieveFromTFileAny(ccdbPath, metadata, bunchCrossing.timestamp()); diff --git a/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx b/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx index 4dfd2409424..f1ab80425f5 100644 --- a/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx +++ b/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx @@ -596,7 +596,7 @@ struct ResonanceInitializer { // Centralicity estimator selection template - float centEst(ResoColl ResoEvents) + float centEst(const ResoColl& ResoEvents) { float returnValue = -999.0; switch (multEstimator) { @@ -673,7 +673,7 @@ struct ResonanceInitializer { } template - float getEvtPl(ResoColl ResoEvents) + float getEvtPl(const ResoColl& ResoEvents) { float returnValue = -999.0; if (ResoEvents.qvecAmp()[evtPlDetId] > 1e-8) @@ -682,7 +682,7 @@ struct ResonanceInitializer { } template - float getEvtPlRes(ResoColl ResoEvents, int a, int b) + float getEvtPlRes(const ResoColl& ResoEvents, int a, int b) { float returnValue = -999.0; if (ResoEvents.qvecAmp()[a] < 1e-8 || ResoEvents.qvecAmp()[b] < 1e-8) diff --git a/PWGLF/TableProducer/Strangeness/cascadeflow.cxx b/PWGLF/TableProducer/Strangeness/cascadeflow.cxx index f5cac87074d..c6b9e0e7009 100644 --- a/PWGLF/TableProducer/Strangeness/cascadeflow.cxx +++ b/PWGLF/TableProducer/Strangeness/cascadeflow.cxx @@ -438,7 +438,7 @@ struct cascadeFlow { } template - bool IsCascAccepted(TCascade casc, TDaughter negExtra, TDaughter posExtra, TDaughter bachExtra, int& counter) // loose cuts on topological selections of cascades + bool IsCascAccepted(const TCascade& casc, const TDaughter& negExtra, const TDaughter& posExtra, const TDaughter& bachExtra, int& counter) // loose cuts on topological selections of cascades { // TPC cuts as those implemented for the training of the signal if (doNTPCSigmaCut) { @@ -476,7 +476,7 @@ struct cascadeFlow { } template - bool isLambdaAccepted(TDaughter negExtra, TDaughter posExtra, int& counter) // loose cuts on topological selections of v0s + bool isLambdaAccepted(const TDaughter& negExtra, const TDaughter& posExtra, int& counter) // loose cuts on topological selections of v0s { // TPC cuts as those implemented for the training of the signal if (doNTPCSigmaCut) { @@ -492,7 +492,7 @@ struct cascadeFlow { return true; } template - bool isAntiLambdaAccepted(TDaughter negExtra, TDaughter posExtra, int& counter) // loose cuts on topological selections of v0s + bool isAntiLambdaAccepted(const TDaughter& negExtra, const TDaughter& posExtra, int& counter) // loose cuts on topological selections of v0s { // TPC cuts as those implemented for the training of the signal if (doNTPCSigmaCut) { @@ -509,7 +509,7 @@ struct cascadeFlow { } template - bool isV0TopoAccepted(TV0 v0) + bool isV0TopoAccepted(const TV0& v0) { // topological selections if (v0.v0radius() < V0Configs.v0radius) @@ -582,7 +582,7 @@ struct cascadeFlow { std::string fullCCDBShiftCorrPathTPCR; template - double ApplyShiftCorrection(TCollision coll, double psiT0C, TProfile3D* shiftprofile) + double ApplyShiftCorrection(const TCollision& coll, double psiT0C, TProfile3D* shiftprofile) { auto deltapsiFT0C = 0.0; int nmode = 2; @@ -597,7 +597,7 @@ struct cascadeFlow { } template - double ComputeEPResolutionwShifts(TCollision coll, double psiT0C, double psiV0A, double psiT0A, double psiTPCA, double psiTPCC, TProfile3D* shiftprofileA, TProfile3D* shiftprofileB, TProfile3D* shiftprofileC, TProfile3D* shiftprofileD, TProfile3D* shiftprofileE) + double ComputeEPResolutionwShifts(const TCollision& coll, double psiT0C, double psiV0A, double psiT0A, double psiTPCA, double psiTPCC, TProfile3D* shiftprofileA, TProfile3D* shiftprofileB, TProfile3D* shiftprofileC, TProfile3D* shiftprofileD, TProfile3D* shiftprofileE) { int nmode = 2; auto deltapsiFT0C = 0.0; @@ -674,7 +674,7 @@ struct cascadeFlow { } template - void fillTrainingTable(collision_t coll, cascade_t casc, int pdgCode) + void fillTrainingTable(const collision_t& coll, const cascade_t& casc, int pdgCode) { trainingSample(coll.centFT0C(), casc.sign(), @@ -699,7 +699,7 @@ struct cascadeFlow { } template - void fillAnalysedTable(collision_t coll, bool hasEventPlane, bool hasSpectatorPlane, cascade_t casc, float v2CSP, float v2CEP, float v1SP_ZDCA, float v1SP_ZDCC, float PsiT0C, float BDTresponseXi, float BDTresponseOmega, int pdgCode, bachExtra_t bachExtra) + void fillAnalysedTable(const collision_t& coll, bool hasEventPlane, bool hasSpectatorPlane, const cascade_t& casc, float v2CSP, float v2CEP, float v1SP_ZDCA, float v1SP_ZDCC, float PsiT0C, float BDTresponseXi, float BDTresponseOmega, int pdgCode, const bachExtra_t& bachExtra) { double masses[nParticles]{o2::constants::physics::MassXiMinus, o2::constants::physics::MassOmegaMinus}; ROOT::Math::PxPyPzMVector cascadeVector[nParticles], lambdaVector, protonVector; @@ -802,7 +802,7 @@ struct cascadeFlow { } template - void fillAnalysedLambdaTable(collision_t coll, bool hasEventPlane, bool hasSpectatorPlane, int chargeIndex, v0_t v0, float v2CEP, float psiT0C, double pzs2Lambda, double cos2ThetaLambda, double cosThetaLambda) + void fillAnalysedLambdaTable(const collision_t& coll, bool hasEventPlane, bool hasSpectatorPlane, int chargeIndex, const v0_t& v0, float v2CEP, float psiT0C, double pzs2Lambda, double cos2ThetaLambda, double cosThetaLambda) { double invMassLambda = 0; if (chargeIndex == 0) diff --git a/PWGLF/TableProducer/Strangeness/cascademcbuilder.cxx b/PWGLF/TableProducer/Strangeness/cascademcbuilder.cxx index 04df29d88c4..614a590caea 100644 --- a/PWGLF/TableProducer/Strangeness/cascademcbuilder.cxx +++ b/PWGLF/TableProducer/Strangeness/cascademcbuilder.cxx @@ -122,7 +122,7 @@ struct cascademcbuilder { } template - void generateCascadeMCinfo(TCascadeTable cascTable, TMCParticleTable mcParticles) + void generateCascadeMCinfo(const TCascadeTable& cascTable, const TMCParticleTable& mcParticles) { // to be used if using the asymmetric mode, kept empty otherwise diff --git a/PWGLF/TableProducer/Strangeness/cascderivedqaanalysis.cxx b/PWGLF/TableProducer/Strangeness/cascderivedqaanalysis.cxx index 6ccb65c9d4d..11129716925 100644 --- a/PWGLF/TableProducer/Strangeness/cascderivedqaanalysis.cxx +++ b/PWGLF/TableProducer/Strangeness/cascderivedqaanalysis.cxx @@ -176,7 +176,7 @@ struct CascDerivedQAanalysis { std::vector> cascadesGrouped; template - bool isCascadeSelected(TCascade casc, TCollision collision, float rapidity, bool isXi) + bool isCascadeSelected(const TCascade& casc, const TCollision& collision, float rapidity, bool isXi) // precalculate this information so that a check is one mask operation, not many { @@ -409,7 +409,7 @@ struct CascDerivedQAanalysis { } template - bool isEventAccepted(TCollision collision, bool fillHists) + bool isEventAccepted(const TCollision& collision, bool fillHists) // check whether the collision passes our collision selections { if (fillHists) { diff --git a/PWGLF/TableProducer/Strangeness/cascqaanalysis.cxx b/PWGLF/TableProducer/Strangeness/cascqaanalysis.cxx index 58aac18208a..ce89b1136b2 100644 --- a/PWGLF/TableProducer/Strangeness/cascqaanalysis.cxx +++ b/PWGLF/TableProducer/Strangeness/cascqaanalysis.cxx @@ -299,7 +299,7 @@ struct Cascqaanalysis { } template - uint16_t getGenNchInFT0Mregion(TMcParticles particles) + uint16_t getGenNchInFT0Mregion(const TMcParticles& particles) { // Particle counting in FITFT0: -3.3<η<-2.1; 3.5<η<4.9 uint16_t nchFT0 = 0; @@ -323,7 +323,7 @@ struct Cascqaanalysis { } template - uint16_t getGenNchInFV0Aregion(TMcParticles particles) + uint16_t getGenNchInFV0Aregion(const TMcParticles& particles) { // Particle counting in FV0A: 2.2<η<5.1 uint16_t nchFV0A = 0; diff --git a/PWGLF/TableProducer/Strangeness/stracents.cxx b/PWGLF/TableProducer/Strangeness/stracents.cxx index a50905d6a41..ad34db13e92 100644 --- a/PWGLF/TableProducer/Strangeness/stracents.cxx +++ b/PWGLF/TableProducer/Strangeness/stracents.cxx @@ -38,6 +38,7 @@ #include #include #include +#include #include using namespace o2; @@ -107,7 +108,7 @@ struct straCents { float mMCScalePars[6] = {0.0}; TFormula* mMCScale = nullptr; explicit CalibrationInfo(std::string name) - : name(name), + : name(std::move(name)), mCalibrationStored(false), mhMultSelCalib(nullptr), mMCScalePars{0.0}, @@ -216,7 +217,7 @@ struct straCents { } template - void initCCDB(TCollision collision) + void initCCDB(const TCollision& collision) { if (mRunNumber == collision.runNumber()) { return; @@ -348,7 +349,7 @@ struct straCents { } } else { // we are in Run 3 - auto getccdb = [lCalibObjects_Centrality, collision](struct CalibrationInfo& estimator, const Configurable generatorName, const Configurable notCrashOnNull) { // TODO: to consider the name inside the estimator structure + auto getccdb = [lCalibObjects_Centrality, collision](struct CalibrationInfo& estimator, const Configurable& generatorName, const Configurable& notCrashOnNull) { // TODO: to consider the name inside the estimator structure estimator.mhMultSelCalib = reinterpret_cast(lCalibObjects_Centrality->FindObject(TString::Format("hCalibZeq%s", estimator.name.c_str()).Data())); estimator.mMCScale = reinterpret_cast(lCalibObjects_Centrality->FindObject(TString::Format("%s-%s", generatorName->c_str(), estimator.name.c_str()).Data())); if (estimator.mhMultSelCalib != nullptr) { diff --git a/PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx b/PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx index 0c07172d25d..8007e538f89 100644 --- a/PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx +++ b/PWGLF/TableProducer/Strangeness/strangederivedbuilder.cxx @@ -280,7 +280,7 @@ struct strangederivedbuilder { } template - void getCfg(o2::framework::InitContext& initContext, const std::string& name, VType& v, const std::string task) + void getCfg(o2::framework::InitContext& initContext, const std::string& name, VType& v, const std::string& task) { if (!o2::common::core::getTaskOptionValue(initContext, task, name, v, inheritEvtSelFromTaskVerbose)) { LOG(fatal) << "Could not get " << name << " from " << task << " task"; diff --git a/PWGLF/Tasks/Nuspex/NucleiHistTask.cxx b/PWGLF/Tasks/Nuspex/NucleiHistTask.cxx index 6ca24667e9a..6239a7b32c3 100644 --- a/PWGLF/Tasks/Nuspex/NucleiHistTask.cxx +++ b/PWGLF/Tasks/Nuspex/NucleiHistTask.cxx @@ -583,7 +583,7 @@ struct NucleiHistTask { if (!isEventSelected(event)) return; - for (auto track : tracks) { // start loop over all tracks + for (const auto& track : tracks) { // start loop over all tracks histTrackcuts_data_spectra->AddBinContent(1); if (event_selection_sel8 && !event.sel8()) @@ -665,7 +665,7 @@ struct NucleiHistTask { auto par = (std::vector)parShiftPt; Particle_Tpc_nSigma_shift->SetParameters(par[0], par[1], par[2], par[3], par[4], par[5]); } - for (auto track : tracks) { + for (const auto& track : tracks) { float TPCnSigma_particle = -100; float TOFnSigma_particle = -100; @@ -886,7 +886,7 @@ struct NucleiHistTask { if (!event_selection_sel8) spectra_reg.fill(HIST("histCentrality"), event.centFT0C()); - for (auto track : tracks) { + for (const auto& track : tracks) { if ((event_selection_sel8 && !event.sel8()) || (enable_Centrality_cut_global && (event.centFT0C() < minCentrality) && (event.centFT0C() > maxCentrality))) continue; diff --git a/PWGLF/Tasks/Nuspex/QAHistTask.cxx b/PWGLF/Tasks/Nuspex/QAHistTask.cxx index 061cad99809..c8ebb7ca97f 100644 --- a/PWGLF/Tasks/Nuspex/QAHistTask.cxx +++ b/PWGLF/Tasks/Nuspex/QAHistTask.cxx @@ -314,7 +314,7 @@ struct QAHistTask { if (!isEventSelected(event)) return; - for (auto track : tracks) { // start loop over all tracks + for (const auto& track : tracks) { // start loop over all tracks if (event_selection_sel8 && !event.sel8()) continue; @@ -564,7 +564,7 @@ struct QAHistTask { if (!isEventSelected(event)) return; - for (auto track : tracks) { + for (const auto& track : tracks) { if (event_selection_sel8 && !event.sel8()) { continue; diff --git a/PWGLF/Tasks/Nuspex/angularCorrelationsInJets.cxx b/PWGLF/Tasks/Nuspex/angularCorrelationsInJets.cxx index a66555f0246..59c8a005ea6 100644 --- a/PWGLF/Tasks/Nuspex/angularCorrelationsInJets.cxx +++ b/PWGLF/Tasks/Nuspex/angularCorrelationsInJets.cxx @@ -618,7 +618,7 @@ struct AngularCorrelationsInJets { } } - void fillMixedEventDeltas(const auto& track, const auto& buffer, int particleType, const TVector3 jetAxis) // correlate tracks from current event with tracks from buffer, i.e. other events + void fillMixedEventDeltas(const auto& track, const auto& buffer, int particleType, const TVector3& jetAxis) // correlate tracks from current event with tracks from buffer, i.e. other events { if (buffer.size() == 0) return; @@ -680,7 +680,7 @@ struct AngularCorrelationsInJets { } // for (int i = 0; i < static_cast(buffer.size()); i++) } - void doCorrelations(const auto& particleVector, const auto& buffer, auto& tempBuffer, int particleType, const TVector3 jetAxis) + void doCorrelations(const auto& particleVector, const auto& buffer, auto& tempBuffer, int particleType, const TVector3& jetAxis) { if (std::isnan(jetAxis.Phi())) return; @@ -743,7 +743,7 @@ struct AngularCorrelationsInJets { } // for (int i = 0; i < static_cast(particleVector.size()); i++) } - void doCorrelationsAnti(const auto& particleVector, const auto& particleVectorAnti, const auto& bufferAnti, auto& tempBuffer, const TVector3 jetAxis) // correlations between proton/antiproton - same story as doCorrelations but different track vectors are correlated + void doCorrelationsAnti(const auto& particleVector, const auto& particleVectorAnti, const auto& bufferAnti, auto& tempBuffer, const TVector3& jetAxis) // correlations between proton/antiproton - same story as doCorrelations but different track vectors are correlated { if (std::isnan(jetAxis.Phi())) return; @@ -775,7 +775,7 @@ struct AngularCorrelationsInJets { } } - void getPerpendicularAxis(TVector3 p, TVector3& u, double sign) + void getPerpendicularAxis(const TVector3& p, TVector3& u, double sign) { // Initialization double ux(0), uy(0), uz(0); @@ -822,7 +822,7 @@ struct AngularCorrelationsInJets { return; } - int analyseJet(int jetCounter, fastjet::PseudoJet jet, const auto& particles, auto& jetProtons, auto& jetAntiprotons, auto& jetPiPlus, auto& jetPiMinus, auto& jetAll, double rhoPerp, double rhoMPerp) + int analyseJet(int jetCounter, const fastjet::PseudoJet& jet, const auto& particles, auto& jetProtons, auto& jetAntiprotons, auto& jetPiPlus, auto& jetPiMinus, auto& jetAll, double rhoPerp, double rhoMPerp) { if (!jet.has_constituents()) return jetCounter; diff --git a/PWGLF/Tasks/Nuspex/antinucleiInJets.cxx b/PWGLF/Tasks/Nuspex/antinucleiInJets.cxx index f2b28bd38bb..68425d16cce 100644 --- a/PWGLF/Tasks/Nuspex/antinucleiInJets.cxx +++ b/PWGLF/Tasks/Nuspex/antinucleiInJets.cxx @@ -686,7 +686,7 @@ struct AntinucleiInJets { } } - void getReweightingHistograms(o2::framework::Service const& ccdbObj, TString filepath, TString antip, TString antilambda, TString antisigma, TString antixi, TString antiomega, TString jet, TString ue) + void getReweightingHistograms(o2::framework::Service const& ccdbObj, const TString& filepath, const TString& antip, const TString& antilambda, const TString& antisigma, const TString& antixi, const TString& antiomega, const TString& jet, const TString& ue) { TList* list = ccdbObj->get(filepath.Data()); if (!list) { diff --git a/PWGLF/Tasks/Nuspex/helium_flow.cxx b/PWGLF/Tasks/Nuspex/helium_flow.cxx index 74f76d1c18e..5dab83c0db3 100644 --- a/PWGLF/Tasks/Nuspex/helium_flow.cxx +++ b/PWGLF/Tasks/Nuspex/helium_flow.cxx @@ -183,7 +183,7 @@ struct helium_flow { bool containsParticleOfInterest(false); // Loop over Reconstructed Tracks - for (auto track : tracks) { + for (const auto& track : tracks) { // Track Selection if (!passedTrackSelection(track)) diff --git a/PWGLF/Tasks/Nuspex/nucleiEbye.cxx b/PWGLF/Tasks/Nuspex/nucleiEbye.cxx index f970a270906..df645514aba 100644 --- a/PWGLF/Tasks/Nuspex/nucleiEbye.cxx +++ b/PWGLF/Tasks/Nuspex/nucleiEbye.cxx @@ -189,7 +189,7 @@ struct nucleiEbye { return true; } - void fillHistoN(std::shared_ptr hFull, std::shared_ptr const& hTmp, int const subsample, int const centrality) + void fillHistoN(const std::shared_ptr& hFull, std::shared_ptr const& hTmp, int const subsample, int const centrality) { for (int iEta{1}; iEta < hTmp->GetNbinsX() + 1; ++iEta) { for (int iPt{1}; iPt < hTmp->GetNbinsY() + 1; ++iPt) { @@ -202,7 +202,7 @@ struct nucleiEbye { } } - void fillHistoN(std::shared_ptr hFull, std::shared_ptr const& hTmpA, std::shared_ptr const& hTmpB, int const subsample, int const centrality) + void fillHistoN(const std::shared_ptr& hFull, std::shared_ptr const& hTmpA, std::shared_ptr const& hTmpB, int const subsample, int const centrality) { for (int iEta{1}; iEta < hTmpA->GetNbinsX() + 1; ++iEta) { auto eta = hTmpA->GetXaxis()->GetBinCenter(iEta); diff --git a/PWGLF/Tasks/Nuspex/nuclei_in_toward_transv_regions.cxx b/PWGLF/Tasks/Nuspex/nuclei_in_toward_transv_regions.cxx index d00f320dbdc..8756a1b46e4 100644 --- a/PWGLF/Tasks/Nuspex/nuclei_in_toward_transv_regions.cxx +++ b/PWGLF/Tasks/Nuspex/nuclei_in_toward_transv_regions.cxx @@ -236,7 +236,7 @@ struct nuclei_in_toward_transv_regions { int i = -1; // Loop over Reconstructed Tracks - for (auto track : tracks) { + for (const auto& track : tracks) { i++; if (!passedTrackSelectionForJetReconstruction(track)) @@ -256,7 +256,7 @@ struct nuclei_in_toward_transv_regions { auto const& leading_track = tracks.iteratorAt(leading_ID); // Loop over Reconstructed Tracks - for (auto track : tracks) { + for (const auto& track : tracks) { // Track Selection if (!passedTrackSelection(track)) @@ -319,7 +319,7 @@ struct nuclei_in_toward_transv_regions { int i = -1; // Loop over Reconstructed Tracks - for (auto track : tracks_per_coll) { + for (const auto& track : tracks_per_coll) { i++; if (!passedTrackSelectionForJetReconstruction(track)) @@ -338,7 +338,7 @@ struct nuclei_in_toward_transv_regions { auto const& leading_track = tracks_per_coll.iteratorAt(leading_ID); // Loop over Reconstructed Tracks - for (auto track : tracks_per_coll) { + for (const auto& track : tracks_per_coll) { if (!passedTrackSelection(track)) continue; diff --git a/PWGLF/Tasks/Nuspex/spectraKinkPiKa.cxx b/PWGLF/Tasks/Nuspex/spectraKinkPiKa.cxx index 3adeefd79ee..7d2bb8bcd0a 100644 --- a/PWGLF/Tasks/Nuspex/spectraKinkPiKa.cxx +++ b/PWGLF/Tasks/Nuspex/spectraKinkPiKa.cxx @@ -558,7 +558,7 @@ struct SpectraKinkPiKa { } } - double computeMotherMass(ROOT::Math::PxPyPzMVector pmoth, ROOT::Math::PxPyPzMVector pdaug) + double computeMotherMass(const ROOT::Math::PxPyPzMVector& pmoth, const ROOT::Math::PxPyPzMVector& pdaug) { // Infer neutrino momentum from conservation ROOT::Math::XYZVector pnuvec = pmoth.Vect() - pdaug.Vect(); @@ -573,7 +573,7 @@ struct SpectraKinkPiKa { double m2 = etotal * etotal - ptotalsq; return (m2 > 0) ? std::sqrt(m2) : -1.0; } - double computeQt(ROOT::Math::PxPyPzMVector pmoth, ROOT::Math::PxPyPzMVector pdaug) + double computeQt(const ROOT::Math::PxPyPzMVector& pmoth, const ROOT::Math::PxPyPzMVector& pdaug) { TVector3 pdlab(pdaug.Px(), pdaug.Py(), pdaug.Pz()); // Compute transverse component diff --git a/PWGLF/Tasks/QC/efficiencyQA.cxx b/PWGLF/Tasks/QC/efficiencyQA.cxx index c02606e3de1..822b6bb24b6 100644 --- a/PWGLF/Tasks/QC/efficiencyQA.cxx +++ b/PWGLF/Tasks/QC/efficiencyQA.cxx @@ -322,7 +322,7 @@ struct efficiencyQA { } template - void fillHistTrack(T const& track, std::shared_ptr hist, float const& y, float const& z = 1) + void fillHistTrack(T const& track, const std::shared_ptr& hist, float const& y, float const& z = 1) { bool itsAccept = !(track.itsChi2NCl() > 36. || track.itsNCls() < 4); bool tpcAccept = !(track.tpcCrossedRowsOverFindableCls() < 0.8 || track.tpcNClsCrossedRows() < 70 || track.tpcChi2NCl() > 4. || track.tpcNClsFound() < 90); @@ -347,7 +347,7 @@ struct efficiencyQA { } template - void fillHistTrack(T const& track, std::shared_ptr hist, float const& y, float const& z = 1, float const& t = 1) + void fillHistTrack(T const& track, const std::shared_ptr& hist, float const& y, float const& z = 1, float const& t = 1) { bool itsAccept = !(track.itsChi2NCl() > 36. || track.itsNCls() < 4); bool tpcAccept = !(track.tpcCrossedRowsOverFindableCls() < 0.8 || track.tpcNClsCrossedRows() < 70 || track.tpcChi2NCl() > 4. || track.tpcNClsFound() < 90); diff --git a/PWGLF/Tasks/QC/resonanceqa.cxx b/PWGLF/Tasks/QC/resonanceqa.cxx index c4d6b1aac7c..c30eba9fb9b 100644 --- a/PWGLF/Tasks/QC/resonanceqa.cxx +++ b/PWGLF/Tasks/QC/resonanceqa.cxx @@ -275,7 +275,7 @@ struct resonanceqa { histos.fill(HIST("hCentrality"), multiplicity); histos.fill(HIST("hNcontributor"), collision.numContrib()); histos.fill(HIST("hVtxZ"), collision.posZ()); - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -289,7 +289,7 @@ struct resonanceqa { histos.fill(HIST("hNsigmaProtonTPC"), track1.tpcNSigmaPr()); histos.fill(HIST("hNsigmaProtonTOF"), track1.tofNSigmaPr()); auto track1ID = track1.globalIndex(); - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!selectionTrack(track2)) { continue; } @@ -388,7 +388,7 @@ struct resonanceqa { } auto daughtp = false; auto daughtm = false; - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (!kCurrentDaughter.isPhysicalPrimary()) { continue; } @@ -425,7 +425,7 @@ struct resonanceqa { return; } histos.fill(HIST("hMC"), 1.5); - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -433,7 +433,7 @@ struct resonanceqa { continue; } auto track1ID = track1.globalIndex(); - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!track2.has_mcParticle()) { continue; } diff --git a/PWGLF/Tasks/QC/straRecoStudy.cxx b/PWGLF/Tasks/QC/straRecoStudy.cxx index 8482f7eafc1..b191f182677 100644 --- a/PWGLF/Tasks/QC/straRecoStudy.cxx +++ b/PWGLF/Tasks/QC/straRecoStudy.cxx @@ -592,7 +592,7 @@ struct straRecoStudy { PROCESS_SWITCH(straRecoStudy, processV0RealData, "Regular V0 analysis in real data", false); template - void processCascadeCandidate(TCascCandidate casc) + void processCascadeCandidate(const TCascCandidate& casc) { // MC association if (!casc.has_collision()) { diff --git a/PWGLF/Tasks/QC/strderivedGenQA.cxx b/PWGLF/Tasks/QC/strderivedGenQA.cxx index 4d1c2878d26..b9223226614 100644 --- a/PWGLF/Tasks/QC/strderivedGenQA.cxx +++ b/PWGLF/Tasks/QC/strderivedGenQA.cxx @@ -518,7 +518,7 @@ struct strderivedGenQA { } template - bool IsEventAccepted(TCollision collision) + bool IsEventAccepted(const TCollision& collision) // check whether the collision passes our collision selections { if (eventSelections.requireSel8 && !collision.sel8()) { diff --git a/PWGLF/Tasks/QC/v0cascadesqa.cxx b/PWGLF/Tasks/QC/v0cascadesqa.cxx index 99c7d37699c..4beab4e9572 100644 --- a/PWGLF/Tasks/QC/v0cascadesqa.cxx +++ b/PWGLF/Tasks/QC/v0cascadesqa.cxx @@ -456,7 +456,7 @@ struct v0cascadesQA { } template - bool isEventAccepted(TCollision collision, bool fillHists) + bool isEventAccepted(const TCollision& collision, bool fillHists) // check whether the collision passes our collision selections { if (fillHists) { @@ -625,7 +625,7 @@ struct v0cascadesQA { } template - bool isV0Accepted(TV0 v0, TCollision collision, float rapidity, int v0Type) + bool isV0Accepted(const TV0& v0, const TCollision& collision, float rapidity, int v0Type) // precalculate this information so that a check is one mask operation, not many { // Base topological variables @@ -816,7 +816,7 @@ struct v0cascadesQA { } template - bool isCascadeSelected(TCascade casc, TCollision collision, float rapidity, int cascType) + bool isCascadeSelected(const TCascade& casc, const TCollision& collision, float rapidity, int cascType) // precalculate this information so that a check is one mask operation, not many { // @@ -1030,7 +1030,7 @@ struct v0cascadesQA { } template - bool checkV0MCAssociation(TV0 v0, int v0Type) + bool checkV0MCAssociation(const TV0& v0, int v0Type) // precalculate this information so that a check is one mask operation, not many { if (!v0.isPhysicalPrimary()) @@ -1054,7 +1054,7 @@ struct v0cascadesQA { } template - bool checkCascadeMCAssociation(TCascade casc, int cascType) + bool checkCascadeMCAssociation(const TCascade& casc, int cascType) // precalculate this information so that a check is one mask operation, not many { if (!casc.isPhysicalPrimary()) diff --git a/PWGLF/Tasks/QC/vertexQA.cxx b/PWGLF/Tasks/QC/vertexQA.cxx index 9dab5ce7f10..45aef295193 100644 --- a/PWGLF/Tasks/QC/vertexQA.cxx +++ b/PWGLF/Tasks/QC/vertexQA.cxx @@ -45,7 +45,7 @@ namespace { constexpr double LHCRFFreq = 400.789e6; constexpr double LHCBunchSpacingNS = 10 * 1.e9 / LHCRFFreq; -double deltaTimeColl(BCcoll const bccoll1, BCcoll const bccoll2) +double deltaTimeColl(BCcoll const& bccoll1, BCcoll const& bccoll2) { auto coll1 = std::get(bccoll1); auto coll2 = std::get(bccoll2); @@ -271,7 +271,7 @@ struct vertexQA { std::vector jumps{0ll}; int64_t lastBC = bcs.rawIteratorAt(0).globalBC(); - for (auto bc : bcs) { + for (const auto& bc : bcs) { if (bc.globalBC() - lastBC > 3564 * 32) { // 32 orbits jumps.push_back(bc.globalIndex()); lastBC = bc.globalBC(); @@ -279,7 +279,7 @@ struct vertexQA { } uint64_t jumpsSentinel{1}; std::vector collisionsIndices{0ll}; - for (auto col : collisions) { + for (const auto& col : collisions) { if (jumpsSentinel == jumps.size()) { break; } diff --git a/PWGLF/Tasks/Resonances/doubleResonanceScan.cxx b/PWGLF/Tasks/Resonances/doubleResonanceScan.cxx index bc81e47c208..44e196fb8e3 100644 --- a/PWGLF/Tasks/Resonances/doubleResonanceScan.cxx +++ b/PWGLF/Tasks/Resonances/doubleResonanceScan.cxx @@ -213,7 +213,7 @@ struct DoubleResonanceScan { } template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { if constexpr (!IsResoMicrotrack) { if (std::abs(track.pt()) < cMinPtcut) diff --git a/PWGLF/Tasks/Resonances/doublephimeson.cxx b/PWGLF/Tasks/Resonances/doublephimeson.cxx index a14647b525a..20715e68208 100644 --- a/PWGLF/Tasks/Resonances/doublephimeson.cxx +++ b/PWGLF/Tasks/Resonances/doublephimeson.cxx @@ -241,8 +241,8 @@ struct doublephimeson { // get kstar TLorentzVector trackSum, PartOneCMS, PartTwoCMS, trackRelK; - float getkstar(const TLorentzVector part1, - const TLorentzVector part2) + float getkstar(const TLorentzVector& part1, + const TLorentzVector& part2) { // const TLorentzVector trackSum = part1 + part2; trackSum = part1 + part2; @@ -262,8 +262,8 @@ struct doublephimeson { return 0.5 * trackRelK.P(); } - float deepangle2(const ROOT::Math::PtEtaPhiMVector candidate1, - const ROOT::Math::PtEtaPhiMVector candidate2) + float deepangle2(const ROOT::Math::PtEtaPhiMVector& candidate1, + const ROOT::Math::PtEtaPhiMVector& candidate2) { double pt1, pt2, pz1, pz2, p1, p2, angle; pt1 = candidate1.Pt(); @@ -276,8 +276,8 @@ struct doublephimeson { return angle; } - float deepangle(const TLorentzVector candidate1, - const TLorentzVector candidate2) + float deepangle(const TLorentzVector& candidate1, + const TLorentzVector& candidate2) { double pt1, pt2, pz1, pz2, p1, p2, angle; pt1 = candidate1.Pt(); @@ -293,8 +293,8 @@ struct doublephimeson { // get cosTheta TLorentzVector daughterCMS; ROOT::Math::XYZVector threeVecDauCM, threeVecMother; - float getCosTheta(const TLorentzVector mother, - const TLorentzVector daughter) + float getCosTheta(const TLorentzVector& mother, + const TLorentzVector& daughter) { threeVecMother = mother.Vect(); const float beta = mother.Beta(); @@ -837,7 +837,7 @@ struct doublephimeson { return; } int phimult = 0; - for (auto phitrackd1 : phitracks) { + for (const auto& phitrackd1 : phitracks) { if (phitrackd1.phiMass() < minPhiMass1 || phitrackd1.phiMass() > maxPhiMass1) { continue; } @@ -857,7 +857,7 @@ struct doublephimeson { } phimult = phimult + 1; } - for (auto phitrackd1 : phitracks) { + for (const auto& phitrackd1 : phitracks) { auto kaonplusd1pt = TMath::Sqrt(phitrackd1.phid1Px() * phitrackd1.phid1Px() + phitrackd1.phid1Py() * phitrackd1.phid1Py()); auto kaonminusd1pt = TMath::Sqrt(phitrackd1.phid2Px() * phitrackd1.phid2Px() + phitrackd1.phid2Py() * phitrackd1.phid2Py()); if (kaonplusd1pt > maxKaonPt) { @@ -880,7 +880,7 @@ struct doublephimeson { Phid1.SetXYZM(phitrackd1.phiPx(), phitrackd1.phiPy(), phitrackd1.phiPz(), phitrackd1.phiMass()); Phi1kaonplus.SetXYZM(phitrackd1.phid1Px(), phitrackd1.phid1Py(), phitrackd1.phid1Pz(), 0.493); Phi1kaonminus.SetXYZM(phitrackd1.phid2Px(), phitrackd1.phid2Py(), phitrackd1.phid2Pz(), 0.493); - for (auto phitrackd2 : phitracks) { + for (const auto& phitrackd2 : phitracks) { auto phid2id = phitrackd2.index(); if (phid2id <= phid1id) { continue; @@ -973,7 +973,7 @@ struct doublephimeson { } int phimult = 0; - for (auto phitrackd1 : phitracks) { + for (const auto& phitrackd1 : phitracks) { if (phitrackd1.phiMass() < minPhiMass1 || phitrackd1.phiMass() > maxPhiMass1) { continue; } @@ -993,7 +993,7 @@ struct doublephimeson { } phimult = phimult + 1; } - for (auto phitrackd1 : phitracks) { + for (const auto& phitrackd1 : phitracks) { auto kaonplusd1pt = TMath::Sqrt(phitrackd1.phid1Px() * phitrackd1.phid1Px() + phitrackd1.phid1Py() * phitrackd1.phid1Py()); auto kaonminusd1pt = TMath::Sqrt(phitrackd1.phid2Px() * phitrackd1.phid2Px() + phitrackd1.phid2Py() * phitrackd1.phid2Py()); @@ -1021,7 +1021,7 @@ struct doublephimeson { Phid1.SetXYZM(phitrackd1.phiPx(), phitrackd1.phiPy(), phitrackd1.phiPz(), phitrackd1.phiMass()); Phi1kaonplus.SetXYZM(phitrackd1.phid1Px(), phitrackd1.phid1Py(), phitrackd1.phid1Pz(), 0.493); Phi1kaonminus.SetXYZM(phitrackd1.phid2Px(), phitrackd1.phid2Py(), phitrackd1.phid2Pz(), 0.493); - for (auto phitrackd2 : phitracks) { + for (const auto& phitrackd2 : phitracks) { auto phid2id = phitrackd2.index(); if (phid2id <= phid1id) { continue; @@ -1088,14 +1088,14 @@ struct doublephimeson { for (auto if1 = exoticresonance.begin(); if1 != exoticresonance.end(); ++if1) { auto i5 = std::distance(exoticresonance.begin(), if1); - auto exotic1phi1 = phiresonanced1.at(i5); - auto exotic1phi2 = phiresonanced2.at(i5); + const auto& exotic1phi1 = phiresonanced1.at(i5); + const auto& exotic1phi2 = phiresonanced2.at(i5); auto exotic1 = exoticresonance.at(i5); - auto exotic1kaonplus1 = kaonplus1.at(i5); - auto exotic1kaonminus1 = kaonminus1.at(i5); - auto exotic1kaonplus2 = kaonplus2.at(i5); - auto exotic1kaonminus2 = kaonminus2.at(i5); + const auto& exotic1kaonplus1 = kaonplus1.at(i5); + const auto& exotic1kaonminus1 = kaonminus1.at(i5); + const auto& exotic1kaonplus2 = kaonplus2.at(i5); + const auto& exotic1kaonminus2 = kaonminus2.at(i5); auto deltaRkaonplus1 = TMath::Sqrt(TMath::Power(exotic1kaonplus1.Phi() - exotic1kaonplus2.Phi(), 2.0) + TMath::Power(exotic1kaonplus1.Eta() - exotic1kaonplus2.Eta(), 2.0)); auto deltaRkaonminus1 = TMath::Sqrt(TMath::Power(exotic1kaonminus1.Phi() - exotic1kaonminus2.Phi(), 2.0) + TMath::Power(exotic1kaonminus1.Eta() - exotic1kaonminus2.Eta(), 2.0)); histos.fill(HIST("hDeltaRkaonplus"), deltaRkaonplus1); @@ -1113,14 +1113,14 @@ struct doublephimeson { for (auto if2 = if1 + 1; if2 != exoticresonance.end(); ++if2) { auto i6 = std::distance(exoticresonance.begin(), if2); - auto exotic2phi1 = phiresonanced1.at(i6); - auto exotic2phi2 = phiresonanced2.at(i6); + const auto& exotic2phi1 = phiresonanced1.at(i6); + const auto& exotic2phi2 = phiresonanced2.at(i6); auto exotic2 = exoticresonance.at(i6); - auto exotic2kaonplus1 = kaonplus1.at(i6); - auto exotic2kaonminus1 = kaonminus1.at(i6); - auto exotic2kaonplus2 = kaonplus2.at(i6); - auto exotic2kaonminus2 = kaonminus2.at(i6); + const auto& exotic2kaonplus1 = kaonplus1.at(i6); + const auto& exotic2kaonminus1 = kaonminus1.at(i6); + const auto& exotic2kaonplus2 = kaonplus2.at(i6); + const auto& exotic2kaonminus2 = kaonminus2.at(i6); auto deltaRkaonplus2 = TMath::Sqrt(TMath::Power(exotic2kaonplus1.Phi() - exotic2kaonplus2.Phi(), 2.0) + TMath::Power(exotic2kaonplus1.Eta() - exotic2kaonplus2.Eta(), 2.0)); auto deltaRkaonminus2 = TMath::Sqrt(TMath::Power(exotic2kaonminus1.Phi() - exotic2kaonminus2.Phi(), 2.0) + TMath::Power(exotic2kaonminus1.Eta() - exotic2kaonminus2.Eta(), 2.0)); @@ -1146,14 +1146,14 @@ struct doublephimeson { } else { for (auto if1 = exoticresonance.begin(); if1 != exoticresonance.end(); ++if1) { auto i5 = std::distance(exoticresonance.begin(), if1); - auto exotic1phi1 = phiresonanced1.at(i5); - auto exotic1phi2 = phiresonanced2.at(i5); + const auto& exotic1phi1 = phiresonanced1.at(i5); + const auto& exotic1phi2 = phiresonanced2.at(i5); auto exotic1 = exoticresonance.at(i5); - auto exotic1kaonplus1 = kaonplus1.at(i5); - auto exotic1kaonminus1 = kaonminus1.at(i5); - auto exotic1kaonplus2 = kaonplus2.at(i5); - auto exotic1kaonminus2 = kaonminus2.at(i5); + const auto& exotic1kaonplus1 = kaonplus1.at(i5); + const auto& exotic1kaonminus1 = kaonminus1.at(i5); + const auto& exotic1kaonplus2 = kaonplus2.at(i5); + const auto& exotic1kaonminus2 = kaonminus2.at(i5); auto deltaRkaonplus1 = TMath::Sqrt(TMath::Power(exotic1kaonplus1.Phi() - exotic1kaonplus2.Phi(), 2.0) + TMath::Power(exotic1kaonplus1.Eta() - exotic1kaonplus2.Eta(), 2.0)); auto deltaRkaonminus1 = TMath::Sqrt(TMath::Power(exotic1kaonminus1.Phi() - exotic1kaonminus2.Phi(), 2.0) + TMath::Power(exotic1kaonminus1.Eta() - exotic1kaonminus2.Eta(), 2.0)); auto deltam1 = TMath::Sqrt(TMath::Power(exotic1phi1.M() - 1.0192, 2.0) + TMath::Power(exotic1phi2.M() - 1.0192, 2.0)); diff --git a/PWGLF/Tasks/Resonances/f0980analysis.cxx b/PWGLF/Tasks/Resonances/f0980analysis.cxx index 257e8a464fc..7efd84760e3 100644 --- a/PWGLF/Tasks/Resonances/f0980analysis.cxx +++ b/PWGLF/Tasks/Resonances/f0980analysis.cxx @@ -284,7 +284,7 @@ struct f0980analysis { } template - bool selPion(const TrackType track) + bool selPion(const TrackType& track) { switch (selectType) { case 0: diff --git a/PWGLF/Tasks/Resonances/f0980pbpbanalysis.cxx b/PWGLF/Tasks/Resonances/f0980pbpbanalysis.cxx index bb40ed8b46e..832b4e47a1a 100644 --- a/PWGLF/Tasks/Resonances/f0980pbpbanalysis.cxx +++ b/PWGLF/Tasks/Resonances/f0980pbpbanalysis.cxx @@ -361,7 +361,7 @@ struct F0980pbpbanalysis { // Event selection template - bool eventSelected(TCollision collision, const bool QA) + bool eventSelected(const TCollision& collision, const bool QA) { if (QAConfig.cfgQAEventCut && QA) fillQA(false, collision, 1); @@ -438,7 +438,7 @@ struct F0980pbpbanalysis { // Track selection template - bool trackSelected(const TrackType track, const bool QA) + bool trackSelected(const TrackType& track, const bool QA) { if (QAConfig.cfgQATrackCut && QA) fillQA(false, track, 3); @@ -519,7 +519,7 @@ struct F0980pbpbanalysis { // PID selection template - bool selectionPID(const TrackType track, const bool QA) + bool selectionPID(const TrackType& track, const bool QA) { if (QA) fillQA(false, track, 4); @@ -580,7 +580,7 @@ struct F0980pbpbanalysis { } // PID selection template - bool pairAngleSelection(const TrackType1 track1, const TrackType2 track2) + bool pairAngleSelection(const TrackType1& track1, const TrackType2& track2) { double pt1, pt2, pz1, pz2, p1, p2, angle; pt1 = track1.pt(); @@ -597,7 +597,7 @@ struct F0980pbpbanalysis { } template - float getTpcNSigma(const TrackType track) + float getTpcNSigma(const TrackType& track) { if (cfgListPtl == PtlList::PtlPion) { return track.tpcNSigmaPi(); @@ -607,7 +607,7 @@ struct F0980pbpbanalysis { } template - float getTofNSigma(const TrackType track) + float getTofNSigma(const TrackType& track) { if (cfgListPtl == PtlList::PtlPion) { return track.tofNSigmaPi(); diff --git a/PWGLF/Tasks/Resonances/f1protoncorrelation.cxx b/PWGLF/Tasks/Resonances/f1protoncorrelation.cxx index f466066c980..193cc5e105b 100644 --- a/PWGLF/Tasks/Resonances/f1protoncorrelation.cxx +++ b/PWGLF/Tasks/Resonances/f1protoncorrelation.cxx @@ -464,7 +464,7 @@ struct f1protoncorrelation { /// Magnetic field to be provided in Tesla static constexpr float tmpRadiiTPC[9] = {85., 105., 125., 145., 165., 185., 205., 225., 245.}; - float PhiAtSpecificRadiiTPC(const TLorentzVector part1, const TLorentzVector part2, float charge1 = 0, int charge2 = 0, float magfield1 = 0.0, float magfield2 = 0.0) + float PhiAtSpecificRadiiTPC(const TLorentzVector& part1, const TLorentzVector& part2, float charge1 = 0, int charge2 = 0, float magfield1 = 0.0, float magfield2 = 0.0) { float pt1 = part1.Pt(); float phi1 = part1.Phi(); @@ -496,8 +496,8 @@ struct f1protoncorrelation { // get kstar TLorentzVector trackSum, PartOneCMS, PartTwoCMS, trackRelK; - float getkstar(const TLorentzVector part1, - const TLorentzVector part2) + float getkstar(const TLorentzVector& part1, + const TLorentzVector& part2) { // const TLorentzVector trackSum = part1 + part2; trackSum = part1 + part2; @@ -517,7 +517,7 @@ struct f1protoncorrelation { return 0.5 * trackRelK.P(); } - float getmT(const TLorentzVector part1, const TLorentzVector part2) + float getmT(const TLorentzVector& part1, const TLorentzVector& part2) { trackSum = part1 + part2; float kT = 0.5 * trackSum.Pt(); @@ -543,7 +543,7 @@ struct f1protoncorrelation { } lastRunNumber = currentRunNumber; - for (auto f1track : f1tracks) { + for (const auto& f1track : f1tracks) { if (f1track.f1MassKaonKshort() > maxKKS0Mass) { continue; } @@ -593,7 +593,7 @@ struct f1protoncorrelation { if (typeofCombined == 1) { combinedTPC = (f1track.f1d1TPC() - f1track.f1d2TPC()) / (f1track.f1d1TPC() + f1track.f1d2TPC()); } - for (auto protontrack : protontracks) { + for (const auto& protontrack : protontracks) { Proton.SetXYZM(protontrack.protonPx(), protontrack.protonPy(), protontrack.protonPz(), 0.938); if (Proton.Pt() > momentumProtonMax || Proton.Pt() < momentumProtonMin) { continue; @@ -975,7 +975,7 @@ struct f1protoncorrelation { lastRunNumber = currentRunNumber; auto countf1 = 0; - for (auto f1track : f1tracks) { + for (const auto& f1track : f1tracks) { if (f1track.f1MassKaonKshort() > maxKKS0Mass) continue; @@ -1021,7 +1021,7 @@ struct f1protoncorrelation { continue; // Proton loop - for (auto protontrack : protontracks) { + for (const auto& protontrack : protontracks) { Proton.SetXYZM(protontrack.protonPx(), protontrack.protonPy(), protontrack.protonPz(), 0.938); if ((f1track.f1PionIndex() == protontrack.f1ProtonIndex()) || diff --git a/PWGLF/Tasks/Resonances/heptaquark.cxx b/PWGLF/Tasks/Resonances/heptaquark.cxx index 351ff08ab0a..f5da2552359 100644 --- a/PWGLF/Tasks/Resonances/heptaquark.cxx +++ b/PWGLF/Tasks/Resonances/heptaquark.cxx @@ -261,7 +261,7 @@ struct heptaquark { if (collision.numLambda() < 1 || collision.numPhi() < 2) return; - for (auto hqtrackd1 : hqtracks) { + for (const auto& hqtrackd1 : hqtracks) { if (hqtrackd1.hqId() != 333) continue; @@ -289,7 +289,7 @@ struct heptaquark { auto hqd1id = hqtrackd1.index(); histos.fill(HIST("hPhid1Mass"), HQ1.M(), HQ1.Pt()); - for (auto hqtrackd2 : hqtracks) { + for (const auto& hqtrackd2 : hqtracks) { auto hqd2id = hqtrackd2.index(); if (hqd2id <= hqd1id) continue; @@ -325,7 +325,7 @@ struct heptaquark { histos.fill(HIST("hnsigmaTOFKa"), hqtrackd2.hqd2TOF(), DauVec2.Pt()); histos.fill(HIST("hPhid2Mass"), HQ2.M(), HQ2.Pt()); - for (auto hqtrackd3 : hqtracks) { + for (const auto& hqtrackd3 : hqtracks) { if (std::abs(hqtrackd3.hqId()) != 3122) continue; diff --git a/PWGLF/Tasks/Resonances/highmasslambda.cxx b/PWGLF/Tasks/Resonances/highmasslambda.cxx index c0827bfe7d2..cf2df918881 100644 --- a/PWGLF/Tasks/Resonances/highmasslambda.cxx +++ b/PWGLF/Tasks/Resonances/highmasslambda.cxx @@ -591,7 +591,7 @@ struct highmasslambda { histos.fill(HIST("hVtxZ"), collision.posZ()); histos.fill(HIST("hOccupancy"), occupancy); auto firstprimarytrack = 0; - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -626,7 +626,7 @@ struct highmasslambda { histos.fill(HIST("hNsigmaProtonTOF"), track1.tofNSigmaPr(), track1.pt()); } auto track1ID = track1.globalIndex(); - for (auto v0 : V0s) { + for (const auto& v0 : V0s) { if (firstprimarytrack == 0) { histos.fill(HIST("hInvMassKs0before"), v0.mK0Short()); } @@ -872,7 +872,7 @@ struct highmasslambda { histos.fill(HIST("hVtxZ"), collision.posZ()); histos.fill(HIST("hOccupancy"), occupancy); auto firstprimarytrack = 0; - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -906,7 +906,7 @@ struct highmasslambda { auto trackParCovBach = getTrackParCov(track1); // auto trackParCovBach = getTrackParCov(bach); - for (auto v0 : V0s) { + for (const auto& v0 : V0s) { if (!SelectionV0(collision, v0)) { continue; } diff --git a/PWGLF/Tasks/Resonances/highmasslambdasvx.cxx b/PWGLF/Tasks/Resonances/highmasslambdasvx.cxx index cc971733c05..c3ece46c3c8 100644 --- a/PWGLF/Tasks/Resonances/highmasslambdasvx.cxx +++ b/PWGLF/Tasks/Resonances/highmasslambdasvx.cxx @@ -573,7 +573,7 @@ struct highmasslambdasvx { histos.fill(HIST("hVtxZ"), collision.posZ()); histos.fill(HIST("hOccupancy"), occupancy); auto firstprimarytrack = 0; - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -611,7 +611,7 @@ struct highmasslambdasvx { histos.fill(HIST("hNsigmaProtonTOF"), track1.tofNSigmaPr(), track1.pt()); auto track1ID = track1.globalIndex(); auto trackParCovBach = getTrackParCov(track1); - for (auto v0 : V0s) { + for (const auto& v0 : V0s) { if (!SelectionV0(collision, v0)) { continue; } diff --git a/PWGLF/Tasks/Resonances/initializereventqa.cxx b/PWGLF/Tasks/Resonances/initializereventqa.cxx index 81b12b19534..ad8e4e89ea5 100644 --- a/PWGLF/Tasks/Resonances/initializereventqa.cxx +++ b/PWGLF/Tasks/Resonances/initializereventqa.cxx @@ -169,7 +169,7 @@ struct Initializereventqa { Partition globalTracksIUEta05 = (nabs(aod::track::eta) < globalEta05) && (requireGlobalTrackInFilter()); template - uint16_t getGenNchInFT0Mregion(TMcParticles particles) + uint16_t getGenNchInFT0Mregion(const TMcParticles& particles) { float region1FT0 = -3.3f; float region2FT0 = -2.1f; diff --git a/PWGLF/Tasks/Resonances/k1AnalysisMicro.cxx b/PWGLF/Tasks/Resonances/k1AnalysisMicro.cxx index e636df0f774..0cbab0d427c 100644 --- a/PWGLF/Tasks/Resonances/k1AnalysisMicro.cxx +++ b/PWGLF/Tasks/Resonances/k1AnalysisMicro.cxx @@ -265,7 +265,7 @@ struct K1AnalysisMicro { int kK1Plus = 10323; template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { if constexpr (!IsResoMicrotrack) { // basic track cuts diff --git a/PWGLF/Tasks/Resonances/k892analysis.cxx b/PWGLF/Tasks/Resonances/k892analysis.cxx index 8dea9031fc7..ee26e771a1e 100644 --- a/PWGLF/Tasks/Resonances/k892analysis.cxx +++ b/PWGLF/Tasks/Resonances/k892analysis.cxx @@ -320,7 +320,7 @@ struct K892analysis { double massPi = MassPionCharged; template - bool eventSelected(TCollision collision, const float& centrality) + bool eventSelected(const TCollision& collision, const float& centrality) { // if (collision.alias_bit(kTVXinTRD)) { // // TRD triggered @@ -342,7 +342,7 @@ struct K892analysis { } template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { // basic track cuts if (std::abs(track.pt()) < cMinPtcut) diff --git a/PWGLF/Tasks/Resonances/k892pmanalysis.cxx b/PWGLF/Tasks/Resonances/k892pmanalysis.cxx index 0abd5992a29..f30d7c1ae28 100644 --- a/PWGLF/Tasks/Resonances/k892pmanalysis.cxx +++ b/PWGLF/Tasks/Resonances/k892pmanalysis.cxx @@ -197,7 +197,7 @@ struct k892pmanalysis { double massAntiLambda0 = MassLambda0Bar; template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { // basic track cuts if (std::abs(track.pt()) < cMinPtcut) @@ -219,7 +219,7 @@ struct k892pmanalysis { } template - bool V0Cut(const V0Type v0) + bool V0Cut(const V0Type& v0) { // V0 track cuts if (std::abs(v0.eta()) > cMaxV0Etacut) diff --git a/PWGLF/Tasks/Resonances/kaonkaonanalysis.cxx b/PWGLF/Tasks/Resonances/kaonkaonanalysis.cxx index 55d41750b35..19abecac1e1 100644 --- a/PWGLF/Tasks/Resonances/kaonkaonanalysis.cxx +++ b/PWGLF/Tasks/Resonances/kaonkaonanalysis.cxx @@ -454,7 +454,7 @@ struct kaonkaonAnalysisRun3 { histos.fill(HIST("multdist_FT0A"), collision.multFT0A()); histos.fill(HIST("multdist_FT0C"), collision.multFT0C()); } - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -467,7 +467,7 @@ struct kaonkaonAnalysisRun3 { histos.fill(HIST("hNsigmaKaonTOF_TPC_before"), track1.tofNSigmaKa(), track1.tpcNSigmaKa()); } auto track1ID = track1.index(); - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!selectionTrack(track2)) { continue; } @@ -605,7 +605,7 @@ struct kaonkaonAnalysisRun3 { } auto daughtp = false; auto daughtm = false; - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (!kCurrentDaughter.isPhysicalPrimary()) { continue; } @@ -634,7 +634,7 @@ struct kaonkaonAnalysisRun3 { histos.fill(HIST("Recmutiplicity"), multiplicity); histos.fill(HIST("hMC"), 5.5); auto oldindex = -999; - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -642,7 +642,7 @@ struct kaonkaonAnalysisRun3 { continue; } auto track1ID = track1.index(); - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!track2.has_mcParticle()) { continue; } diff --git a/PWGLF/Tasks/Resonances/kstar0analysis.cxx b/PWGLF/Tasks/Resonances/kstar0analysis.cxx index 3cbc9f29503..4755b2e0a0b 100644 --- a/PWGLF/Tasks/Resonances/kstar0analysis.cxx +++ b/PWGLF/Tasks/Resonances/kstar0analysis.cxx @@ -436,7 +436,7 @@ struct Kstar0analysis { // Centralicity estimator selection template - float centEst(Coll collisions) + float centEst(const Coll& collisions) { float returnValue = -999.0f; switch (centEstimator) { @@ -503,7 +503,7 @@ struct Kstar0analysis { } template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { // basic track cuts if (configTracks.cDCAr7SigCut && std::abs(track.dcaXY()) > (0.004f + 0.013f / (track.pt()))) // 7 - Sigma cut diff --git a/PWGLF/Tasks/Resonances/kstar892analysis.cxx b/PWGLF/Tasks/Resonances/kstar892analysis.cxx index ad8b6d9e3d8..3e7626203df 100644 --- a/PWGLF/Tasks/Resonances/kstar892analysis.cxx +++ b/PWGLF/Tasks/Resonances/kstar892analysis.cxx @@ -331,7 +331,7 @@ struct kstar892analysis { float massPi = MassPionCharged; template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { // TPC if (track.tpcNClsFound() < cfgTPCcluster) diff --git a/PWGLF/Tasks/Resonances/kstarInOO.cxx b/PWGLF/Tasks/Resonances/kstarInOO.cxx index 0a3e99db80c..d16f1be1818 100644 --- a/PWGLF/Tasks/Resonances/kstarInOO.cxx +++ b/PWGLF/Tasks/Resonances/kstarInOO.cxx @@ -963,7 +963,7 @@ struct kstarInOO { } // TrackSlicingMC template - double DistinguishJets(const JetType& jets, ROOT::Math::PxPyPzMVector& lResonance) + double DistinguishJets(const JetType& jets, const ROOT::Math::PxPyPzMVector& lResonance) { if (cDebugLevel > 0) { LOG(info) << "Found multiple jets to the same phi."; @@ -1176,7 +1176,7 @@ struct kstarInOO { bool HasJets = false; int nJets = 0; - for (auto chargedjet : chargedjets) { + for (const auto& chargedjet : chargedjets) { if (std::abs(chargedjet.eta()) > (cfgJetMaxEta - cfgJetdR)) { continue; } @@ -1263,7 +1263,7 @@ struct kstarInOO { bool HasJets = false; int nJets = 0; - for (auto mcdjet : mcdjets) { + for (const auto& mcdjet : mcdjets) { if (std::abs(mcdjet.eta()) > cfgJetMaxEta - cfgJetdR) { continue; } diff --git a/PWGLF/Tasks/Resonances/lambda1405analysis.cxx b/PWGLF/Tasks/Resonances/lambda1405analysis.cxx index 83eb796ac94..06385d1a370 100644 --- a/PWGLF/Tasks/Resonances/lambda1405analysis.cxx +++ b/PWGLF/Tasks/Resonances/lambda1405analysis.cxx @@ -839,7 +839,7 @@ struct lambda1405analysis { aod::KinkCands::iterator const& sigmaCand, TracksFull const& tracks, std::vector& selectedCandidates, - TBinningType binPolicy) + const TBinningType& binPolicy) { lambda1405candidate lambda1405Cand{}; @@ -1112,7 +1112,7 @@ struct lambda1405analysis { } template - void fillOutputData(const TCollision& collision, const TCand& sigmaCands, const TTrack& tracks, TBinningType binPolicy) + void fillOutputData(const TCollision& collision, const TCand& sigmaCands, const TTrack& tracks, const TBinningType& binPolicy) { if (std::abs(collision.posZ()) > eventSelection.cutZVertex || !collision.sel8()) { return; diff --git a/PWGLF/Tasks/Resonances/lambda1520SpherocityAnalysis.cxx b/PWGLF/Tasks/Resonances/lambda1520SpherocityAnalysis.cxx index 390bfd1768a..d5543744f89 100644 --- a/PWGLF/Tasks/Resonances/lambda1520SpherocityAnalysis.cxx +++ b/PWGLF/Tasks/Resonances/lambda1520SpherocityAnalysis.cxx @@ -345,7 +345,7 @@ struct lambdaAnalysis { // kinematic cuts method template - bool kinCuts(trackType trkPr, trackType trkKa, T p, float& alpha) + bool kinCuts(const trackType& trkPr, const trackType& trkKa, const T& p, float& alpha) { // initialize std::vector kinCutsPt = static_cast>(cKinCutsPt); diff --git a/PWGLF/Tasks/Resonances/lambda1520analysis.cxx b/PWGLF/Tasks/Resonances/lambda1520analysis.cxx index d09b4f18dda..b45c29e6070 100644 --- a/PWGLF/Tasks/Resonances/lambda1520analysis.cxx +++ b/PWGLF/Tasks/Resonances/lambda1520analysis.cxx @@ -356,7 +356,7 @@ struct Lambda1520analysis { double massPr = MassProton; template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { // basic track cuts if (std::abs(track.pt()) < cMinPtcut) diff --git a/PWGLF/Tasks/Resonances/lambda1520analysisinOO.cxx b/PWGLF/Tasks/Resonances/lambda1520analysisinOO.cxx index 77a0d4403b1..1aa84ce8085 100644 --- a/PWGLF/Tasks/Resonances/lambda1520analysisinOO.cxx +++ b/PWGLF/Tasks/Resonances/lambda1520analysisinOO.cxx @@ -438,7 +438,7 @@ struct Lstaranalysis { // Centralicity estimator selection template - float centEst(ResoColl ResoEvents) + float centEst(const ResoColl& ResoEvents) { float returnValue = -999.0; switch (multEstimator) { @@ -477,7 +477,7 @@ struct Lstaranalysis { } template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { // basic track cuts if (std::abs(track.pt()) < cMinPtcut) diff --git a/PWGLF/Tasks/Resonances/lambdav2.cxx b/PWGLF/Tasks/Resonances/lambdav2.cxx index ea87a33f1fb..59d6e11bd2c 100644 --- a/PWGLF/Tasks/Resonances/lambdav2.cxx +++ b/PWGLF/Tasks/Resonances/lambdav2.cxx @@ -306,7 +306,7 @@ struct lambdav2 { histos.fill(HIST("hpQxpQytvscent"), centrality, QxpQyt); histos.fill(HIST("hpQxtQypvscent"), centrality, QxtQyp); - for (auto track : tracks) { + for (const auto& track : tracks) { if (!selectionTrack(track)) { continue; } diff --git a/PWGLF/Tasks/Resonances/lstarpbpbv2.cxx b/PWGLF/Tasks/Resonances/lstarpbpbv2.cxx index 216cc36f7b0..f62d6f87927 100644 --- a/PWGLF/Tasks/Resonances/lstarpbpbv2.cxx +++ b/PWGLF/Tasks/Resonances/lstarpbpbv2.cxx @@ -420,7 +420,7 @@ struct lstarpbpbv2 { histos.fill(HIST("ResFT0CFT0ASP"), centrality, QFT0C * QFT0A * TMath::Cos(2.0 * (psiFT0C - psiFT0A))); histos.fill(HIST("ResFT0ATPCSP"), centrality, QTPC * QFT0A * TMath::Cos(2.0 * (psiTPC - psiFT0A))); - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -431,7 +431,7 @@ struct lstarpbpbv2 { } track1kaon = true; - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!selectionTrack(track2)) { continue; } diff --git a/PWGLF/Tasks/Resonances/phianalysis.cxx b/PWGLF/Tasks/Resonances/phianalysis.cxx index eff17aa8a87..43a2c49027a 100644 --- a/PWGLF/Tasks/Resonances/phianalysis.cxx +++ b/PWGLF/Tasks/Resonances/phianalysis.cxx @@ -138,7 +138,7 @@ struct phianalysis { double massKa = MassKaonCharged; template - bool trackCut(const TrackType track) + bool trackCut(const TrackType& track) { // basic track cuts if (std::abs(track.pt()) < cMinPtcut) diff --git a/PWGLF/Tasks/Resonances/phianalysisrun3.cxx b/PWGLF/Tasks/Resonances/phianalysisrun3.cxx index b923303eb1d..2d0218171ae 100644 --- a/PWGLF/Tasks/Resonances/phianalysisrun3.cxx +++ b/PWGLF/Tasks/Resonances/phianalysisrun3.cxx @@ -266,7 +266,7 @@ struct phianalysisrun3 { histos.fill(HIST("hCentrality"), multiplicity); histos.fill(HIST("hNcontributor"), collision.numContrib()); histos.fill(HIST("hVtxZ"), collision.posZ()); - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -276,7 +276,7 @@ struct phianalysisrun3 { histos.fill(HIST("hNsigmaKaonTPC"), track1.tpcNSigmaKa()); histos.fill(HIST("hNsigmaKaonTOF"), track1.tofNSigmaKa()); auto track1ID = track1.index(); - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!selectionTrack(track2)) { continue; } @@ -394,7 +394,7 @@ struct phianalysisrun3 { } auto daughtp = false; auto daughtm = false; - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (!kCurrentDaughter.isPhysicalPrimary()) { continue; } @@ -421,7 +421,7 @@ struct phianalysisrun3 { } histos.fill(HIST("hMC"), 5.5); auto oldindex = -999; - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (!selectionTrack(track1)) { continue; } @@ -429,7 +429,7 @@ struct phianalysisrun3 { continue; } auto track1ID = track1.index(); - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (!track2.has_mcParticle()) { continue; } diff --git a/PWGLF/Tasks/Resonances/phipbpb.cxx b/PWGLF/Tasks/Resonances/phipbpb.cxx index 21e731f8964..ca124250f26 100644 --- a/PWGLF/Tasks/Resonances/phipbpb.cxx +++ b/PWGLF/Tasks/Resonances/phipbpb.cxx @@ -635,7 +635,7 @@ struct phipbpb { int Npostrack = 0; float weight1 = 1.0; float weight2 = 1.0; - for (auto track1 : posThisColl) { + for (const auto& track1 : posThisColl) { // track selection if (!selectionTrack(track1)) { continue; @@ -673,7 +673,7 @@ struct phipbpb { weight1 = 1; } } - for (auto track2 : negThisColl) { + for (const auto& track2 : negThisColl) { // track selection if (!selectionTrack(track2)) { continue; @@ -862,7 +862,7 @@ struct phipbpb { } int Npostrack = 0; - for (auto track1 : posThisColl) { + for (const auto& track1 : posThisColl) { // track selection if (!selectionTrack(track1)) { continue; @@ -881,7 +881,7 @@ struct phipbpb { continue; } auto track1ID = track1.globalIndex(); - for (auto track2 : negThisColl) { + for (const auto& track2 : negThisColl) { // track selection if (!selectionTrack(track2)) { continue; @@ -1465,7 +1465,7 @@ struct phipbpb { auto oldindex = -999; auto Rectrackspart = RecTracks.sliceBy(perCollision, RecCollision.globalIndex()); // loop over reconstructed particle - for (auto track1 : Rectrackspart) { + for (const auto& track1 : Rectrackspart) { if (!selectionTrack(track1)) { continue; } @@ -1479,7 +1479,7 @@ struct phipbpb { continue; } auto track1ID = track1.index(); - for (auto track2 : Rectrackspart) { + for (const auto& track2 : Rectrackspart) { auto track2ID = track2.index(); if (track2ID <= track1ID) { continue; @@ -1576,7 +1576,7 @@ struct phipbpb { } auto daughtp = false; auto daughtm = false; - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (!kCurrentDaughter.isPhysicalPrimary()) { continue; } @@ -1760,7 +1760,7 @@ struct phipbpb { auto oldindex = -999; auto Rectrackspart = RecTracks.sliceBy(perCollision, RecCollision.globalIndex()); // loop over reconstructed particle - for (auto track1 : Rectrackspart) { + for (const auto& track1 : Rectrackspart) { if (!track1.has_mcParticle()) { continue; } @@ -1775,7 +1775,7 @@ struct phipbpb { histos.fill(HIST("hSparsePhiMCRecKaonMissMatchWeight"), centclass, GetPhiInRange(mctrack1.phi() - psiFT0C), TMath::Power(TMath::Cos(4.0 * GetPhiInRange(mctrack1.phi() - psiFT0C)), 1.0), mctrack1.pt(), mctrack1.eta()); } auto track1ID = track1.index(); - for (auto track2 : Rectrackspart) { + for (const auto& track2 : Rectrackspart) { if (!track2.has_mcParticle()) { continue; } @@ -1854,7 +1854,7 @@ struct phipbpb { } auto daughtp = false; auto daughtm = false; - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (!kCurrentDaughter.isPhysicalPrimary()) { continue; } diff --git a/PWGLF/Tasks/Resonances/phispectrapbpbqa.cxx b/PWGLF/Tasks/Resonances/phispectrapbpbqa.cxx index 061c8bd7a6c..d26a5b66045 100644 --- a/PWGLF/Tasks/Resonances/phispectrapbpbqa.cxx +++ b/PWGLF/Tasks/Resonances/phispectrapbpbqa.cxx @@ -362,7 +362,7 @@ struct phispectrapbpbqa { int Npostrack = 0; histos.fill(HIST("hOccupancy"), occupancy, centrality); - for (auto track1 : posThisColl) { + for (const auto& track1 : posThisColl) { if (!selectionTrack(track1)) { continue; } @@ -409,7 +409,7 @@ struct phispectrapbpbqa { // 1) φ at a chosen radius (e.g., outer pad rows ~247 cm) histos.fill(HIST("hPhiMommentum"), track1.phi(), track1.p(), occupancy); - for (auto track2 : negThisColl) { + for (const auto& track2 : negThisColl) { if (track1.sign() * track2.sign() > 0.0) { continue; } @@ -643,7 +643,7 @@ struct phispectrapbpbqa { auto Rectrackspart = RecTracks.sliceBy(perCollision, RecCollision.globalIndex()); // loop over reconstructed particle int ntrack1 = 0; - for (auto track1 : Rectrackspart) { + for (const auto& track1 : Rectrackspart) { if (!selectionTrack(track1)) { continue; } @@ -677,7 +677,7 @@ struct phispectrapbpbqa { histos.fill(HIST("hNsigmaTOFAfterCut"), nSigmaTOF, track1.p(), occupancy); } ntrack1 = ntrack1 + 1; - for (auto track2 : Rectrackspart) { + for (const auto& track2 : Rectrackspart) { auto track2ID = track2.index(); if (track2ID <= track1ID) { continue; @@ -785,7 +785,7 @@ struct phispectrapbpbqa { } auto daughtp = false; auto daughtm = false; - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (!kCurrentDaughter.isPhysicalPrimary()) { continue; } diff --git a/PWGLF/Tasks/Resonances/phitutorial.cxx b/PWGLF/Tasks/Resonances/phitutorial.cxx index 0cd3fecbbe8..d60c63819e6 100644 --- a/PWGLF/Tasks/Resonances/phitutorial.cxx +++ b/PWGLF/Tasks/Resonances/phitutorial.cxx @@ -81,7 +81,7 @@ struct phitutorial { // PREAMBLE COMPLETE, NOW WE DO HELPER FCNS //**************************************// template - bool eventSelection(const EventType event) + bool eventSelection(const EventType& event) { if (!event.sel8()) return false; @@ -98,7 +98,7 @@ struct phitutorial { }; //********************************************// template - bool trackSelection(const TracksType track) + bool trackSelection(const TracksType& track) { if (!track.isGlobalTrack()) return false; diff --git a/PWGLF/Tasks/Resonances/phitutorial_step0.cxx b/PWGLF/Tasks/Resonances/phitutorial_step0.cxx index 6bd6ab64e3d..f3feee957d8 100644 --- a/PWGLF/Tasks/Resonances/phitutorial_step0.cxx +++ b/PWGLF/Tasks/Resonances/phitutorial_step0.cxx @@ -70,7 +70,7 @@ struct phitutorial_step0 { // PREAMBLE COMPLETE, NOW WE DO HELPER FCNS //**************************************// template - bool eventSelection(const EventType event) + bool eventSelection(const EventType& event) { if (!event.sel8()) // This is required to extract good events return false; diff --git a/PWGLF/Tasks/Resonances/phitutorial_step1.cxx b/PWGLF/Tasks/Resonances/phitutorial_step1.cxx index 1e6c5d129a8..6420ab51139 100644 --- a/PWGLF/Tasks/Resonances/phitutorial_step1.cxx +++ b/PWGLF/Tasks/Resonances/phitutorial_step1.cxx @@ -75,7 +75,7 @@ struct phitutorial_step1 { // PREAMBLE COMPLETE, NOW WE DO HELPER FCNS //**************************************// template - bool eventSelection(const EventType event) + bool eventSelection(const EventType& event) { if (!event.sel8()) // This is required to extract good events return false; diff --git a/PWGLF/Tasks/Resonances/phitutorial_step2.cxx b/PWGLF/Tasks/Resonances/phitutorial_step2.cxx index f1f0285e698..b77cccbea39 100644 --- a/PWGLF/Tasks/Resonances/phitutorial_step2.cxx +++ b/PWGLF/Tasks/Resonances/phitutorial_step2.cxx @@ -75,7 +75,7 @@ struct phitutorial_step2 { // PREAMBLE COMPLETE, NOW WE DO HELPER FCNS //**************************************// template - bool eventSelection(const EventType event) + bool eventSelection(const EventType& event) { if (!event.sel8()) // This is required to extract good events return false; @@ -84,7 +84,7 @@ struct phitutorial_step2 { }; //********************************************// template - bool trackSelection(const TracksType track) + bool trackSelection(const TracksType& track) { if (!track.isGlobalTrack()) return false; diff --git a/PWGLF/Tasks/Resonances/phitutorial_step3.cxx b/PWGLF/Tasks/Resonances/phitutorial_step3.cxx index 5278d1b67f3..c2f072e37d0 100644 --- a/PWGLF/Tasks/Resonances/phitutorial_step3.cxx +++ b/PWGLF/Tasks/Resonances/phitutorial_step3.cxx @@ -81,7 +81,7 @@ struct phitutorial_step3 { // PREAMBLE COMPLETE, NOW WE DO HELPER FCNS //**************************************// template - bool eventSelection(const EventType event) + bool eventSelection(const EventType& event) { if (!event.sel8()) // This is required to extract good events return false; @@ -90,7 +90,7 @@ struct phitutorial_step3 { }; //********************************************// template - bool trackSelection(const TracksType track) + bool trackSelection(const TracksType& track) { if (!track.isGlobalTrack()) return false; diff --git a/PWGLF/Tasks/Resonances/rho770analysis.cxx b/PWGLF/Tasks/Resonances/rho770analysis.cxx index 0b7c7f34d31..b07a83bb07b 100644 --- a/PWGLF/Tasks/Resonances/rho770analysis.cxx +++ b/PWGLF/Tasks/Resonances/rho770analysis.cxx @@ -151,7 +151,7 @@ struct rho770analysis { double massKa = MassKaonCharged; template - bool selTrack(const TrackType track) + bool selTrack(const TrackType& track) { if (std::abs(track.pt()) < cfgMinPt) return false; @@ -194,7 +194,7 @@ struct rho770analysis { } template - bool selPion(const TrackType track) + bool selPion(const TrackType& track) { const auto mode = static_cast(selectTypeInt.value); @@ -223,7 +223,7 @@ struct rho770analysis { } template - bool selKaon(const TrackType track) + bool selKaon(const TrackType& track) { const auto mode = static_cast(selectTypeInt.value); diff --git a/PWGLF/Tasks/Resonances/rhoanalysis.cxx b/PWGLF/Tasks/Resonances/rhoanalysis.cxx index a061f78375e..77f4bd5c1e0 100644 --- a/PWGLF/Tasks/Resonances/rhoanalysis.cxx +++ b/PWGLF/Tasks/Resonances/rhoanalysis.cxx @@ -305,11 +305,11 @@ struct rhoanalysis { if (std::abs(events.mcCollision().posZ()) > cfgCutVertex) { return; } - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { histos.fill(HIST("hNsigmaPionTPCvspT"), track1.pt(), track1.tpcNSigmaPi()); if (abs(track1.tpcNSigmaPi()) > nsigmaCutCombined) continue; - for (auto track2 : tracks) { + for (const auto& track2 : tracks) { if (abs(track2.tpcNSigmaPi()) > nsigmaCutCombined) continue; @@ -367,7 +367,7 @@ struct rhoanalysis { if (kDaughters.size() != 2) continue; - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (!kCurrentDaughter.isPhysicalPrimary()) continue; diff --git a/PWGLF/Tasks/Resonances/rsnanalysis.cxx b/PWGLF/Tasks/Resonances/rsnanalysis.cxx index eefe03403a2..9dd65838d5c 100644 --- a/PWGLF/Tasks/Resonances/rsnanalysis.cxx +++ b/PWGLF/Tasks/Resonances/rsnanalysis.cxx @@ -339,7 +339,7 @@ struct rsn_analysis { std::vector> kNegSelectedPions; // // Loop on Tracks - for (auto kCurrentTrack : kTracks) { + for (const auto& kCurrentTrack : kTracks) { // // Track Selection if (!uIsTrackSelected(kCurrentTrack)) @@ -576,7 +576,7 @@ struct rsn_analysis { std::vector> kNegSelectedPions; // // Loop on Tracks - for (auto kCurrentTrack : kTracks) { + for (const auto& kCurrentTrack : kTracks) { // // Track Selection if (!uIsTrackSelected(kCurrentTrack)) @@ -730,7 +730,7 @@ struct rsn_analysis { { // Loop on all mc particles - for (auto kCurrentParticle : mcParticles) { + for (const auto& kCurrentParticle : mcParticles) { // if (!kCurrentParticle.producedByGenerator()) continue; @@ -744,7 +744,7 @@ struct rsn_analysis { auto kHasKaonp = false; auto kHasKaonm = false; if (kDaughters.size() == 2) { - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (kCurrentDaughter.pdgCode() == +321) kHasKaonp = true; if (kCurrentDaughter.pdgCode() == -321) @@ -763,7 +763,7 @@ struct rsn_analysis { auto kHasKaonp = false; auto kHasKaonm = false; if (kDaughters.size() == 2) { - for (auto kCurrentDaughter : kDaughters) { + for (const auto& kCurrentDaughter : kDaughters) { if (fabs(kCurrentDaughter.pdgCode()) == 321) kHasKaonp = true; if (fabs(kCurrentDaughter.pdgCode()) == 211) diff --git a/PWGLF/Tasks/Resonances/sigma.cxx b/PWGLF/Tasks/Resonances/sigma.cxx index 6081fa5a8e5..487a967e93d 100644 --- a/PWGLF/Tasks/Resonances/sigma.cxx +++ b/PWGLF/Tasks/Resonances/sigma.cxx @@ -286,7 +286,7 @@ struct sigma { rEventSelection.fill(HIST("hVertexZRec"), collision.posZ()); rEventSelection.fill(HIST("hmult"), multiplicity); - for (auto track1 : tracks) { + for (const auto& track1 : tracks) { if (QAbefore) { histos.fill(HIST("hNsigmaPionTPC_before"), track1.tpcNSigmaPi()); diff --git a/PWGLF/Tasks/Resonances/xi1530Analysis.cxx b/PWGLF/Tasks/Resonances/xi1530Analysis.cxx index ae911cf197a..3e5b70c04b1 100644 --- a/PWGLF/Tasks/Resonances/xi1530Analysis.cxx +++ b/PWGLF/Tasks/Resonances/xi1530Analysis.cxx @@ -229,7 +229,7 @@ struct cascadeXiAnalysis { // kinematic cuts method template - bool kinCuts(U trk1, K trk2, T p, float& alpha) + bool kinCuts(const U& trk1, const K& trk2, const T& p, float& alpha) { // initialize std::vector kinCutsPt = static_cast>(cKinCutsPt); diff --git a/PWGLF/Tasks/Resonances/xi1530Analysisqa.cxx b/PWGLF/Tasks/Resonances/xi1530Analysisqa.cxx index d4169378e9f..0ece227edfe 100644 --- a/PWGLF/Tasks/Resonances/xi1530Analysisqa.cxx +++ b/PWGLF/Tasks/Resonances/xi1530Analysisqa.cxx @@ -521,7 +521,7 @@ struct Xi1530Analysisqa { // Primary track selection for the first pion // template - bool primaryTrackCut(const TrackType track) + bool primaryTrackCut(const TrackType& track) { if (std::abs(track.eta()) >= primarytrackConfig.cMaxetacut) return false; @@ -568,7 +568,7 @@ struct Xi1530Analysisqa { // Primary track selection for cascades, Need to more informations for cascades // template - bool cascprimaryTrackCut(const TracksTypeCasc track) + bool cascprimaryTrackCut(const TracksTypeCasc& track) { if (std::abs(track.eta()) >= primarytrackConfig.cMaxetacut) return false; @@ -596,7 +596,7 @@ struct Xi1530Analysisqa { // Topological cuts for cascades template - bool casctopCut(const TracksTypeCasc track) + bool casctopCut(const TracksTypeCasc& track) { // Topological cuts for V0s if (std::abs(track.daughDCA()) >= v0sConfig.cDCALambdaDaugtherscut) diff --git a/PWGLF/Tasks/Strangeness/cascadeAnalysisLightIonsDerivedData.cxx b/PWGLF/Tasks/Strangeness/cascadeAnalysisLightIonsDerivedData.cxx index eeab5969358..33d3c9c51b0 100644 --- a/PWGLF/Tasks/Strangeness/cascadeAnalysisLightIonsDerivedData.cxx +++ b/PWGLF/Tasks/Strangeness/cascadeAnalysisLightIonsDerivedData.cxx @@ -361,7 +361,7 @@ struct CascadeAnalysisLightIonsDerivedData { } template - void initCCDB(TCollision collision) + void initCCDB(const TCollision& collision) { if (mRunNumber == collision.runNumber()) { return; diff --git a/PWGLF/Tasks/Strangeness/cascadecorrelations.cxx b/PWGLF/Tasks/Strangeness/cascadecorrelations.cxx index c73632268dd..48f11561b4f 100644 --- a/PWGLF/Tasks/Strangeness/cascadecorrelations.cxx +++ b/PWGLF/Tasks/Strangeness/cascadecorrelations.cxx @@ -300,7 +300,7 @@ struct CascadeSelector { } template - void fillMatchedHistos(LabeledCascades::iterator rec, int flag, TCollision collision) + void fillMatchedHistos(const LabeledCascades::iterator& rec, int flag, const TCollision& collision) { if (flag == 0) return; diff --git a/PWGLF/Tasks/Strangeness/cascpolsp.cxx b/PWGLF/Tasks/Strangeness/cascpolsp.cxx index 49f642f653d..123f9605154 100644 --- a/PWGLF/Tasks/Strangeness/cascpolsp.cxx +++ b/PWGLF/Tasks/Strangeness/cascpolsp.cxx @@ -243,7 +243,7 @@ struct cascpolsp { } template - bool IsCascAccepted(TCascade casc, collision_t collision) + bool IsCascAccepted(const TCascade& casc, const collision_t& collision) { if (casc.cascradius() < cfgcasc_radius) diff --git a/PWGLF/Tasks/Strangeness/derivedupcanalysis.cxx b/PWGLF/Tasks/Strangeness/derivedupcanalysis.cxx index 766593fd89f..1741b68afa0 100644 --- a/PWGLF/Tasks/Strangeness/derivedupcanalysis.cxx +++ b/PWGLF/Tasks/Strangeness/derivedupcanalysis.cxx @@ -489,7 +489,7 @@ struct Derivedupcanalysis { } template - void fillHistogramsV0(TCand cand, TCollision coll, int gap) + void fillHistogramsV0(const TCand& cand, const TCollision& coll, int gap) { float invMass = 0; float ft0ampl = -1.f; @@ -614,7 +614,7 @@ struct Derivedupcanalysis { } template - void fillHistogramsCasc(TCand cand, TCollision coll, const int gap) + void fillHistogramsCasc(const TCand& cand, const TCollision& coll, const int gap) { float invMass = 0; float centrality = -1.f; diff --git a/PWGLF/Tasks/Strangeness/k0_mixed_events.cxx b/PWGLF/Tasks/Strangeness/k0_mixed_events.cxx index a5932d939a6..6790d9e2c57 100644 --- a/PWGLF/Tasks/Strangeness/k0_mixed_events.cxx +++ b/PWGLF/Tasks/Strangeness/k0_mixed_events.cxx @@ -78,34 +78,37 @@ using RecoTracks = soa::Join; -typedef std::shared_ptr trkType; -typedef std::shared_ptr trkTypeData; +using TrackType = const FilteredTracks::iterator; +using TrackTypePtr = std::shared_ptr; +using TrackTypeData = const RecoTracks::iterator; +using TrackTypeDataPtr = std::shared_ptr; -typedef std::shared_ptr colType; +using ColType = const FilteredCollisions::iterator; +using ColTypePtr = std::shared_ptr; -using MyFemtoPair = o2::aod::singletrackselector::FemtoPair; +using MyFemtoPair = o2::aod::singletrackselector::FemtoPair; class ResoPair : public MyFemtoPair { public: ResoPair() {} - ResoPair(trkType const& first, trkType const& second) : MyFemtoPair(first, second) + ResoPair(TrackTypePtr const& first, TrackTypePtr const& second) : MyFemtoPair(first, second) { setPair(first, second); } - ResoPair(trkType const& first, trkType const& second, const bool& isidentical) : MyFemtoPair(first, second, isidentical) {} + ResoPair(TrackTypePtr const& first, TrackTypePtr const& second, const bool& isidentical) : MyFemtoPair(first, second, isidentical) {} bool isClosePair() const { return MyFemtoPair::IsClosePair(mDeltaEta, mDeltaPhi, mRadius); } void setEtaDiff(const float deta) { mDeltaEta = deta; } void setPhiStarDiff(const float dphi) { mDeltaPhi = dphi; } void setRadius(const float r) { mRadius = r; } - void setPair(trkType const& first, trkType const& second) + void setPair(TrackTypePtr const& first, TrackTypePtr const& second) { MyFemtoPair::SetPair(first, second); lDecayDaughter1.SetPtEtaPhiM(first->pt(), first->eta(), first->phi(), particle_mass(GetPDG1())); lDecayDaughter2.SetPtEtaPhiM(second->pt(), second->eta(), second->phi(), particle_mass(GetPDG2())); lResonance = lDecayDaughter1 + lDecayDaughter2; } - void setPair(trkTypeData const& first, trkTypeData const& second) + void setPair(TrackTypeDataPtr const& first, TrackTypeDataPtr const& second) { // MyFemtoPair::SetPair(first, second); lDecayDaughter1.SetPtEtaPhiM(first->pt(), first->eta(), first->phi(), particle_mass(GetPDG1())); @@ -369,8 +372,8 @@ struct K0MixedEvents { void mixTracks(Type const& tracks1, Type const& tracks2, const float centrality) { LOG(debug) << "Mixing tracks of two different events"; - for (auto trk1 : tracks1) { - for (auto trk2 : tracks2) { + for (const auto& trk1 : tracks1) { + for (const auto& trk2 : tracks2) { Pair->setPair(trk1, trk2); @@ -529,9 +532,9 @@ struct K0MixedEvents { void processDerived(FilteredTracks const& tracks, FilteredCollisions const& collisions) { LOG(debug) << "Processing " << collisions.size() << " collisions and " << tracks.size() << " tracks"; - std::map> selectedtracks_1; - std::map> selectedtracks_2; - std::map, std::vector> mixbins; + std::map> selectedtracks_1; + std::map> selectedtracks_2; + std::map, std::vector> mixbins; if (_particlePDG_1 == 0 || _particlePDG_2 == 0) { LOGF(fatal, "One of passed PDG is 0!!!"); } @@ -542,7 +545,7 @@ struct K0MixedEvents { registry.fill(HIST("multPerc"), collision.multPerc()); } - for (auto track : tracks) { + for (const auto& track : tracks) { LOG(debug) << "Track index " << track.singleCollSelId(); if (!isTrackSelected(track)) { continue; @@ -559,7 +562,7 @@ struct K0MixedEvents { if ((track.sign() == _sign_1) && (track.p() < _PIDtrshld_1 ? o2::aod::singletrackselector::TPCselection(track, TPCcuts_1) : o2::aod::singletrackselector::TOFselection(track, TOFcuts_1))) { // filling the map: eventID <-> selected particles1 - selectedtracks_1[track.singleCollSelId()].push_back(std::make_shared(track)); + selectedtracks_1[track.singleCollSelId()].push_back(std::make_shared(track)); registry.fill(HIST("p_first"), track.p()); registry.fill(HIST("dcaXY_first"), track.pt(), track.dcaXY()); @@ -591,7 +594,7 @@ struct K0MixedEvents { } else if ((track.sign() == _sign_2) && (_particlePDGtoReject != 0 || !o2::aod::singletrackselector::TOFselection(track, std::make_pair(_particlePDGtoReject, _rejectWithinNsigmaTOF))) && (track.p() < _PIDtrshld_2 ? o2::aod::singletrackselector::TPCselection(track, TPCcuts_2) : o2::aod::singletrackselector::TOFselection(track, TOFcuts_2))) { // filling the map: eventID <-> selected particles2 if (see condition above ^) - selectedtracks_2[track.singleCollSelId()].push_back(std::make_shared(track)); + selectedtracks_2[track.singleCollSelId()].push_back(std::make_shared(track)); registry.fill(HIST("p_second"), track.p()); registry.fill(HIST("dcaXY_second"), track.pt(), track.dcaXY()); @@ -619,7 +622,7 @@ struct K0MixedEvents { } } - for (auto collision : collisions) { + for (const auto& collision : collisions) { if (selectedtracks_1.find(collision.globalIndex()) == selectedtracks_1.end()) { if (IsIdentical) continue; @@ -627,7 +630,7 @@ struct K0MixedEvents { continue; } - mixbins[std::pair{round(collision.posZ() / _vertexbinwidth), floor(collision.mult() / _multbinwidth)}].push_back(std::make_shared(collision)); + mixbins[std::pair{round(collision.posZ() / _vertexbinwidth), floor(collision.mult() / _multbinwidth)}].push_back(std::make_shared(collision)); } //====================================== mixing starts here ====================================== @@ -711,15 +714,15 @@ struct K0MixedEvents { { initCCDB(bcs.iteratorAt(0)); LOG(debug) << "Processing " << collisions.size() << " collisions and " << tracks.size() << " tracks"; - std::map> selectedtracks_1; - std::map> selectedtracks_2; - std::map, std::vector>> mixbins; + std::map> selectedtracks_1; + std::map> selectedtracks_2; + std::map, std::vector>> mixbins; if (_particlePDG_1 == 0 || _particlePDG_2 == 0) { LOGF(fatal, "One of passed PDG is 0!!!"); } registry.fill(HIST("Trks"), 2.f, tracks.size()); - for (auto collision : collisions) { + for (const auto& collision : collisions) { if (!acceptEvent(collision)) continue; LOG(debug) << "Collision index " << collision.globalIndex(); @@ -727,7 +730,7 @@ struct K0MixedEvents { registry.fill(HIST("multPerc"), collision.centFT0M()); } - for (auto track : tracks) { + for (const auto& track : tracks) { if (!isTrackSelected(track)) { continue; } @@ -757,7 +760,7 @@ struct K0MixedEvents { if ((track.sign() == _sign_1) && (track.p() < _PIDtrshld_1 ? o2::aod::singletrackselector::TPCselection(track, TPCcuts_1) : o2::aod::singletrackselector::TOFselection(track, TOFcuts_1))) { // filling the map: eventID <-> selected particles1 - selectedtracks_1[track.collisionId()].push_back(std::make_shared(track)); + selectedtracks_1[track.collisionId()].push_back(std::make_shared(track)); registry.fill(HIST("p_first"), track.p()); registry.fill(HIST("dcaXY_first"), track.pt(), track.dcaXY()); @@ -789,7 +792,7 @@ struct K0MixedEvents { } else if ((track.sign() == _sign_2) && (_particlePDGtoReject != 0 || !o2::aod::singletrackselector::TOFselection(track, std::make_pair(_particlePDGtoReject, _rejectWithinNsigmaTOF))) && (track.p() < _PIDtrshld_2 ? o2::aod::singletrackselector::TPCselection(track, TPCcuts_2) : o2::aod::singletrackselector::TOFselection(track, TOFcuts_2))) { // filling the map: eventID <-> selected particles2 if (see condition above ^) - selectedtracks_2[track.collisionId()].push_back(std::make_shared(track)); + selectedtracks_2[track.collisionId()].push_back(std::make_shared(track)); registry.fill(HIST("p_second"), track.p()); registry.fill(HIST("dcaXY_second"), track.pt(), track.dcaXY()); @@ -817,7 +820,7 @@ struct K0MixedEvents { } } - for (auto collision : collisions) { + for (const auto& collision : collisions) { if (selectedtracks_1.find(collision.globalIndex()) == selectedtracks_1.end()) { if (IsIdentical) continue; @@ -825,7 +828,7 @@ struct K0MixedEvents { continue; } - mixbins[std::pair{round(collision.posZ() / _vertexbinwidth), floor(collision.multNTracksPVeta1() / _multbinwidth)}].push_back(std::make_shared(collision)); + mixbins[std::pair{round(collision.posZ() / _vertexbinwidth), floor(collision.multNTracksPVeta1() / _multbinwidth)}].push_back(std::make_shared(collision)); } //====================================== mixing starts here ====================================== diff --git a/PWGLF/Tasks/Strangeness/lambdakzeroanalysisMC.cxx b/PWGLF/Tasks/Strangeness/lambdakzeroanalysisMC.cxx index e95ac8eb5ee..2b43a75921d 100644 --- a/PWGLF/Tasks/Strangeness/lambdakzeroanalysisMC.cxx +++ b/PWGLF/Tasks/Strangeness/lambdakzeroanalysisMC.cxx @@ -256,7 +256,7 @@ struct lambdakzeroAnalysisMc { } if (particleMotherOfNeg.has_mothers()) { auto particleGrandMothersOfNegTable = particleMotherOfNeg.mothers_as(); - auto particleGrandMotherOfNeg = particleGrandMothersOfNegTable[0]; + const auto& particleGrandMotherOfNeg = particleGrandMothersOfNegTable[0]; if (particleGrandMotherOfNeg.pdgCode() == 3312 || particleGrandMotherOfNeg.pdgCode() == 3322) { registry.fill(HIST("hLambdaFeedDownMatrix"), particleMotherOfNeg.pt(), particleGrandMotherOfNeg.pt()); } @@ -289,7 +289,7 @@ struct lambdakzeroAnalysisMc { } if (particleMotherOfNeg.has_mothers()) { auto particleGrandMothersOfNegTable = particleMotherOfNeg.mothers_as(); - auto particleGrandMotherOfNeg = particleGrandMothersOfNegTable[0]; + const auto& particleGrandMotherOfNeg = particleGrandMothersOfNegTable[0]; if (particleGrandMotherOfNeg.pdgCode() == -3312 || particleGrandMotherOfNeg.pdgCode() == -3322) { registry.fill(HIST("hAntiLambdaFeedDownMatrix"), particleMotherOfNeg.pt(), particleGrandMotherOfNeg.pt()); } diff --git a/PWGLF/Tasks/Strangeness/lambdalambda.cxx b/PWGLF/Tasks/Strangeness/lambdalambda.cxx index 47ba728a94a..d3659397339 100644 --- a/PWGLF/Tasks/Strangeness/lambdalambda.cxx +++ b/PWGLF/Tasks/Strangeness/lambdalambda.cxx @@ -224,7 +224,7 @@ struct lambdalambda { ROOT::Math::PxPyPzMVector RecoV02Rot, RecoV0V0Rot; template - bool eventSelected(TCollision collision) + bool eventSelected(const TCollision& collision) { if (!collision.sel8()) { return 0; diff --git a/PWGLF/Tasks/Strangeness/lambdapolarization.cxx b/PWGLF/Tasks/Strangeness/lambdapolarization.cxx index a35a319ef3b..df2e1f48373 100644 --- a/PWGLF/Tasks/Strangeness/lambdapolarization.cxx +++ b/PWGLF/Tasks/Strangeness/lambdapolarization.cxx @@ -397,7 +397,7 @@ struct lambdapolarization { ROOT::Math::PxPyPzMVector ProtonVec, PionVec, LambdaVec, ProtonBoostedVec, PionBoostedVec; template - bool eventSelected(TCollision collision) + bool eventSelected(const TCollision& collision) { if (!collision.sel8()) { return 0; diff --git a/PWGLF/Tasks/Strangeness/strangeCascTrack.cxx b/PWGLF/Tasks/Strangeness/strangeCascTrack.cxx index 65f4484fdb2..6d115211d88 100644 --- a/PWGLF/Tasks/Strangeness/strangeCascTrack.cxx +++ b/PWGLF/Tasks/Strangeness/strangeCascTrack.cxx @@ -170,7 +170,7 @@ struct StrangeCascTrack { } // checks general selection criteria for collisions template - bool isValidEvent(TEvent collision, bool fillHists) + bool isValidEvent(const TEvent& collision, bool fillHists) { bool passedAllSels = true; //* inel>0 cut @@ -238,7 +238,7 @@ struct StrangeCascTrack { } // checks cascade pt template - bool isValidPt(TCascade cascade, TString particle, int Type) + bool isValidPt(const TCascade& cascade, const TString& particle, int Type) { bool passedSel = true; double ptMin = 0.0; @@ -265,7 +265,7 @@ struct StrangeCascTrack { } // checks general selection criteria for cascades template - std::array isValidCasc(TEvent collision, TCascade cascade, TStdCascade stdcasc, TString particle) + std::array isValidCasc(const TEvent& collision, const TCascade& cascade, const TStdCascade& stdcasc, const TString& particle) { bool passedAllSels = true; // cascade rapidity @@ -342,7 +342,7 @@ struct StrangeCascTrack { } // checks TPC PID of dau tracks template - bool passesTPC(TCascade cascade, TString particle) + bool passesTPC(const TCascade& cascade, const TString& particle) { bool passedSel = true; const auto& posTrack = cascade.template posTrackExtra_as(); @@ -375,7 +375,7 @@ struct StrangeCascTrack { } // checks TOF PID of dau tracks template - bool passesTOF(TCascade cascade, TString particle) + bool passesTOF(const TCascade& cascade, const TString& particle) { bool passedSel = true; if (particle == "Xi") @@ -386,7 +386,7 @@ struct StrangeCascTrack { } // checks whether gen cascade corresponds to PDG code template - bool isValidPDG(TCascade cascade, TString particle) + bool isValidPDG(const TCascade& cascade, const TString& particle) { if (particle == "Xi" && std::abs(cascade.pdgCode()) == PDG_t::kXiMinus) return true; @@ -396,7 +396,7 @@ struct StrangeCascTrack { } // checks whether rec cascade is a truth primary xi or omega template - bool isMCTruth(const TCascade& cascade, TString particle) + bool isMCTruth(const TCascade& cascade, const TString& particle) { if constexpr (requires { cascade.has_cascMCCore(); }) { // safety check: discard rec cascade without gen reference auto cascmccore = cascade.template cascMCCore_as(); @@ -413,7 +413,7 @@ struct StrangeCascTrack { // applies selections for and fills histograms template - void analyseCascade(TEvent collision, TCasc cascade) + void analyseCascade(const TEvent& collision, TCasc cascade) { if constexpr (requires { cascade.topologyChi2(); }) { if (!cascade.has_standardCascade()) diff --git a/PWGLF/Tasks/Strangeness/strangenessInJetsIons.cxx b/PWGLF/Tasks/Strangeness/strangenessInJetsIons.cxx index 6f6a013eb70..0226cd533c7 100644 --- a/PWGLF/Tasks/Strangeness/strangenessInJetsIons.cxx +++ b/PWGLF/Tasks/Strangeness/strangenessInJetsIons.cxx @@ -1449,7 +1449,7 @@ struct StrangenessInJetsIons { // Return true if McCollisions has at least 1 RECO collisions that passed event selections template - bool HasRecoEvent(int mcCollIndex, RecoColls recoCollisions) + bool HasRecoEvent(int mcCollIndex, const RecoColls& recoCollisions) { for (const auto& recoColl : recoCollisions) { if (mcCollIndex == recoColl.mcCollisionId()) { @@ -1569,7 +1569,7 @@ struct StrangenessInJetsIons { // Fill Minimum Bias histograms template - void FillMBEventHistoMCREC(MCRecoCollision collision, + void FillMBEventHistoMCREC(const MCRecoCollision& collision, aod::McParticles const& mcParticles, V0PerColl const& v0sPerColl, CascPerColl const& cascPerColl, @@ -1777,7 +1777,7 @@ struct StrangenessInJetsIons { } template - void fillFeeddownMatrix(TV0 v0, float pt, float centrality, bool passedLambda, bool passedAntiLambda) + void fillFeeddownMatrix(const TV0& v0, float pt, float centrality, bool passedLambda, bool passedAntiLambda) // Fill feeddown matrix for Lambdas or AntiLambdas // Adapted from: PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx { diff --git a/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx b/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx index 3dea781c798..01c2bf31acc 100644 --- a/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx +++ b/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx @@ -351,7 +351,7 @@ struct strangenessderivedbinnedinfo { } template - bool isEventAccepted(TCollision collision, bool fillHists) + bool isEventAccepted(const TCollision& collision, bool fillHists) // check whether the collision passes our collision selections { if (fillHists) @@ -499,7 +499,7 @@ struct strangenessderivedbinnedinfo { } template - void fillEventHistograms(TCollision collision, float& centrality, float& occupancy) + void fillEventHistograms(const TCollision& collision, float& centrality, float& occupancy) { if (isPP) { // centrality = collision.centFT0M(); @@ -516,7 +516,7 @@ struct strangenessderivedbinnedinfo { } template - bool isV0Selected(TV0 v0, TCollision collision, float rapidity) + bool isV0Selected(const TV0& v0, const TCollision& collision, float rapidity) // precalculate this information so that a check is one mask operation, not many { // @@ -644,7 +644,7 @@ struct strangenessderivedbinnedinfo { } template - bool isCascadeSelected(TCascade casc, TCollision collision, float rapidity) + bool isCascadeSelected(const TCascade& casc, const TCollision& collision, float rapidity) // precalculate this information so that a check is one mask operation, not many { // diff --git a/PWGLF/Utils/nucleiUtils.h b/PWGLF/Utils/nucleiUtils.h index 7ecf6a3207f..4d06854cefb 100644 --- a/PWGLF/Utils/nucleiUtils.h +++ b/PWGLF/Utils/nucleiUtils.h @@ -330,7 +330,7 @@ constexpr int EvSelDefault[evSel::kNevSels][1]{ {0}}; template -bool eventSelection(const Tcollision& collision, o2::framework::HistogramRegistry& registry, o2::framework::LabeledArray eventSelections, const float cutVertex, uint32_t& selectionFlag) +bool eventSelection(const Tcollision& collision, o2::framework::HistogramRegistry& registry, const o2::framework::LabeledArray& eventSelections, const float cutVertex, uint32_t& selectionFlag) { selectionFlag = 0; bool isSelected = true; @@ -391,7 +391,7 @@ bool eventSelection(const Tcollision& collision, o2::framework::HistogramRegistr * then fills 1. if the centrality filling fails (return = -1.) */ template -float getCentrality(Tcollision const& collision, const int centralityEstimator, std::shared_ptr hFailCentrality = nullptr) +float getCentrality(Tcollision const& collision, const int centralityEstimator, const std::shared_ptr& hFailCentrality = nullptr) { if (hFailCentrality) { hFailCentrality->Fill(0.); diff --git a/PWGLF/Utils/pidTOFGeneric.h b/PWGLF/Utils/pidTOFGeneric.h index 18b3a937565..8625db1f4e8 100644 --- a/PWGLF/Utils/pidTOFGeneric.h +++ b/PWGLF/Utils/pidTOFGeneric.h @@ -68,14 +68,14 @@ struct TOFCalibConfig { } template - void getCfg(o2::framework::InitContext& initContext, const std::string name, VType& v, const std::string task) + void getCfg(o2::framework::InitContext& initContext, const std::string& name, VType& v, const std::string& task) { if (!o2::common::core::getTaskOptionValue(initContext, task, name, v, false)) { LOG(fatal) << "Could not get " << name << " from " << task << " task"; } } - void inheritFromBaseTask(o2::framework::InitContext& initContext, const std::string task = "tof-signal") + void inheritFromBaseTask(o2::framework::InitContext& initContext, const std::string& task = "tof-signal") { mInitMode = 2; getCfg(initContext, "ccdb-url", mUrl, task); diff --git a/PWGLF/Utils/rsnOutput.h b/PWGLF/Utils/rsnOutput.h index 214d6aa8118..d325548e8c6 100644 --- a/PWGLF/Utils/rsnOutput.h +++ b/PWGLF/Utils/rsnOutput.h @@ -80,7 +80,7 @@ enum class MixingType { none }; -MixingType mixingTypeName(std::string name) +MixingType mixingTypeName(const std::string& name) { if (name == "ce") return MixingType::ce; @@ -217,7 +217,7 @@ class Output virtual void fillRotationpm(double* point) = 0; virtual void fillSystematics(double* point) = 0; - PairAxisType type(std::string name) + PairAxisType type(const std::string& name) { auto it = std::find(pair_axis::names.begin(), pair_axis::names.end(), name); if (it == pair_axis::names.end()) { @@ -226,7 +226,7 @@ class Output return static_cast(std::distance(pair_axis::names.begin(), it)); } - SystematicsAxisType typeSys(std::string name) + SystematicsAxisType typeSys(const std::string& name) { auto it = std::find(systematic_axis::names.begin(), systematic_axis::names.end(), name); if (it == systematic_axis::names.end()) {